Skip to content

Commit 9d38649

Browse files
hassiebphassiebp
authored
fix(dataset-run-items): correctly typ datasetRunItems.list (#1242)
1 parent 2163794 commit 9d38649

File tree

2 files changed

+10
-142
lines changed

2 files changed

+10
-142
lines changed

‎langfuse/api/reference.md‎

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -1308,11 +1308,7 @@ List dataset run items
13081308
<dd>
13091309

13101310
```python
1311-
import datetime
1312-
1313-
from langfuse import DatasetRunItem, PaginatedDatasetRunItems
13141311
from langfuse.client import FernLangfuse
1315-
from langfuse.resources.utils import MetaResponse
13161312

13171313
client = FernLangfuse(
13181314
x_langfuse_sdk_name="YOUR_X_LANGFUSE_SDK_NAME",
@@ -1325,42 +1321,6 @@ client = FernLangfuse(
13251321
client.dataset_run_items.list(
13261322
dataset_id="datasetId",
13271323
run_name="runName",
1328-
response=PaginatedDatasetRunItems(
1329-
data=[
1330-
DatasetRunItem(
1331-
id="id",
1332-
dataset_run_id="datasetRunId",
1333-
dataset_run_name="datasetRunName",
1334-
dataset_item_id="datasetItemId",
1335-
trace_id="traceId",
1336-
created_at=datetime.datetime.fromisoformat(
1337-
"2024-01-15 09:30:00+00:00",
1338-
),
1339-
updated_at=datetime.datetime.fromisoformat(
1340-
"2024-01-15 09:30:00+00:00",
1341-
),
1342-
),
1343-
DatasetRunItem(
1344-
id="id",
1345-
dataset_run_id="datasetRunId",
1346-
dataset_run_name="datasetRunName",
1347-
dataset_item_id="datasetItemId",
1348-
trace_id="traceId",
1349-
created_at=datetime.datetime.fromisoformat(
1350-
"2024-01-15 09:30:00+00:00",
1351-
),
1352-
updated_at=datetime.datetime.fromisoformat(
1353-
"2024-01-15 09:30:00+00:00",
1354-
),
1355-
),
1356-
],
1357-
meta=MetaResponse(
1358-
page=1,
1359-
limit=1,
1360-
total_items=1,
1361-
total_pages=1,
1362-
),
1363-
),
13641324
)
13651325

13661326
```
@@ -1393,14 +1353,6 @@ client.dataset_run_items.list(
13931353
<dl>
13941354
<dd>
13951355

1396-
**response:** `PaginatedDatasetRunItems`
1397-
1398-
</dd>
1399-
</dl>
1400-
1401-
<dl>
1402-
<dd>
1403-
14041356
**page:** `typing.Optional[int]` — page number, starts at 1
14051357

14061358
</dd>

‎langfuse/api/resources/dataset_run_items/client.py‎

Lines changed: 10 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
from ...core.api_error import ApiError
77
from ...core.client_wrapper import AsyncClientWrapper, SyncClientWrapper
8-
from ...core.jsonable_encoder import jsonable_encoder
98
from ...core.pydantic_utilities import pydantic_v1
109
from ...core.request_options import RequestOptions
1110
from ..commons.errors.access_denied_error import AccessDeniedError
@@ -103,11 +102,10 @@ def list(
103102
*,
104103
dataset_id: str,
105104
run_name: str,
106-
response: PaginatedDatasetRunItems,
107105
page: typing.Optional[int] = None,
108106
limit: typing.Optional[int] = None,
109107
request_options: typing.Optional[RequestOptions] = None,
110-
) -> None:
108+
) -> PaginatedDatasetRunItems:
111109
"""
112110
List dataset run items
113111
@@ -117,8 +115,6 @@ def list(
117115
118116
run_name : str
119117
120-
response : PaginatedDatasetRunItems
121-
122118
page : typing.Optional[int]
123119
page number, starts at 1
124120
@@ -130,15 +126,11 @@ def list(
130126
131127
Returns
132128
-------
133-
None
129+
PaginatedDatasetRunItems
134130
135131
Examples
136132
--------
137-
import datetime
138-
139-
from langfuse import DatasetRunItem, PaginatedDatasetRunItems
140133
from langfuse.client import FernLangfuse
141-
from langfuse.resources.utils import MetaResponse
142134
143135
client = FernLangfuse(
144136
x_langfuse_sdk_name="YOUR_X_LANGFUSE_SDK_NAME",
@@ -151,42 +143,6 @@ def list(
151143
client.dataset_run_items.list(
152144
dataset_id="datasetId",
153145
run_name="runName",
154-
response=PaginatedDatasetRunItems(
155-
data=[
156-
DatasetRunItem(
157-
id="id",
158-
dataset_run_id="datasetRunId",
159-
dataset_run_name="datasetRunName",
160-
dataset_item_id="datasetItemId",
161-
trace_id="traceId",
162-
created_at=datetime.datetime.fromisoformat(
163-
"2024-01-15 09:30:00+00:00",
164-
),
165-
updated_at=datetime.datetime.fromisoformat(
166-
"2024-01-15 09:30:00+00:00",
167-
),
168-
),
169-
DatasetRunItem(
170-
id="id",
171-
dataset_run_id="datasetRunId",
172-
dataset_run_name="datasetRunName",
173-
dataset_item_id="datasetItemId",
174-
trace_id="traceId",
175-
created_at=datetime.datetime.fromisoformat(
176-
"2024-01-15 09:30:00+00:00",
177-
),
178-
updated_at=datetime.datetime.fromisoformat(
179-
"2024-01-15 09:30:00+00:00",
180-
),
181-
),
182-
],
183-
meta=MetaResponse(
184-
page=1,
185-
limit=1,
186-
total_items=1,
187-
total_pages=1,
188-
),
189-
),
190146
)
191147
"""
192148
_response = self._client_wrapper.httpx_client.request(
@@ -197,13 +153,14 @@ def list(
197153
"runName": run_name,
198154
"page": page,
199155
"limit": limit,
200-
"response": jsonable_encoder(response),
201156
},
202157
request_options=request_options,
203158
)
204159
try:
205160
if 200 <= _response.status_code < 300:
206-
return
161+
return pydantic_v1.parse_obj_as(
162+
PaginatedDatasetRunItems, _response.json()
163+
) # type: ignore
207164
if _response.status_code == 400:
208165
raise Error(pydantic_v1.parse_obj_as(typing.Any, _response.json())) # type: ignore
209166
if _response.status_code == 401:
@@ -318,11 +275,10 @@ async def list(
318275
*,
319276
dataset_id: str,
320277
run_name: str,
321-
response: PaginatedDatasetRunItems,
322278
page: typing.Optional[int] = None,
323279
limit: typing.Optional[int] = None,
324280
request_options: typing.Optional[RequestOptions] = None,
325-
) -> None:
281+
) -> PaginatedDatasetRunItems:
326282
"""
327283
List dataset run items
328284
@@ -332,8 +288,6 @@ async def list(
332288
333289
run_name : str
334290
335-
response : PaginatedDatasetRunItems
336-
337291
page : typing.Optional[int]
338292
page number, starts at 1
339293
@@ -345,16 +299,13 @@ async def list(
345299
346300
Returns
347301
-------
348-
None
302+
PaginatedDatasetRunItems
349303
350304
Examples
351305
--------
352306
import asyncio
353-
import datetime
354307
355-
from langfuse import DatasetRunItem, PaginatedDatasetRunItems
356308
from langfuse.client import AsyncFernLangfuse
357-
from langfuse.resources.utils import MetaResponse
358309
359310
client = AsyncFernLangfuse(
360311
x_langfuse_sdk_name="YOUR_X_LANGFUSE_SDK_NAME",
@@ -370,42 +321,6 @@ async def main() -> None:
370321
await client.dataset_run_items.list(
371322
dataset_id="datasetId",
372323
run_name="runName",
373-
response=PaginatedDatasetRunItems(
374-
data=[
375-
DatasetRunItem(
376-
id="id",
377-
dataset_run_id="datasetRunId",
378-
dataset_run_name="datasetRunName",
379-
dataset_item_id="datasetItemId",
380-
trace_id="traceId",
381-
created_at=datetime.datetime.fromisoformat(
382-
"2024-01-15 09:30:00+00:00",
383-
),
384-
updated_at=datetime.datetime.fromisoformat(
385-
"2024-01-15 09:30:00+00:00",
386-
),
387-
),
388-
DatasetRunItem(
389-
id="id",
390-
dataset_run_id="datasetRunId",
391-
dataset_run_name="datasetRunName",
392-
dataset_item_id="datasetItemId",
393-
trace_id="traceId",
394-
created_at=datetime.datetime.fromisoformat(
395-
"2024-01-15 09:30:00+00:00",
396-
),
397-
updated_at=datetime.datetime.fromisoformat(
398-
"2024-01-15 09:30:00+00:00",
399-
),
400-
),
401-
],
402-
meta=MetaResponse(
403-
page=1,
404-
limit=1,
405-
total_items=1,
406-
total_pages=1,
407-
),
408-
),
409324
)
410325
411326
@@ -419,13 +334,14 @@ async def main() -> None:
419334
"runName": run_name,
420335
"page": page,
421336
"limit": limit,
422-
"response": jsonable_encoder(response),
423337
},
424338
request_options=request_options,
425339
)
426340
try:
427341
if 200 <= _response.status_code < 300:
428-
return
342+
return pydantic_v1.parse_obj_as(
343+
PaginatedDatasetRunItems, _response.json()
344+
) # type: ignore
429345
if _response.status_code == 400:
430346
raise Error(pydantic_v1.parse_obj_as(typing.Any, _response.json())) # type: ignore
431347
if _response.status_code == 401:

0 commit comments

Comments
 (0)