Skip to content

Commit d951399

Browse files
authored
fix(openai): handle usage object without mutation (#1101)
1 parent 2f5018e commit d951399

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

langfuse/openai.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ def _parse_usage(usage=None):
460460
if usage is None:
461461
return
462462

463-
usage_dict = usage.copy() if isinstance(usage, dict) else usage.__dict__
463+
usage_dict = usage.copy() if isinstance(usage, dict) else usage.__dict__.copy()
464464

465465
for tokens_details in ["prompt_tokens_details", "completion_tokens_details"]:
466466
if tokens_details in usage_dict and usage_dict[tokens_details] is not None:

tests/test_openai.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def test_openai_chat_completion():
7070
{"content": "1 + 1 = ", "role": "user"},
7171
]
7272
assert generation.data[0].type == "GENERATION"
73-
assert generation.data[0].model == "gpt-3.5-turbo-0125"
73+
assert "gpt-3.5-turbo-0125" in generation.data[0].model
7474
assert generation.data[0].start_time is not None
7575
assert generation.data[0].end_time is not None
7676
assert generation.data[0].start_time < generation.data[0].end_time
@@ -135,7 +135,7 @@ def test_openai_chat_completion_stream():
135135

136136
assert generation.data[0].input == [{"content": "1 + 1 = ", "role": "user"}]
137137
assert generation.data[0].type == "GENERATION"
138-
assert generation.data[0].model == "gpt-3.5-turbo-0125"
138+
assert "gpt-3.5-turbo-0125" in generation.data[0].model
139139
assert generation.data[0].start_time is not None
140140
assert generation.data[0].end_time is not None
141141
assert generation.data[0].start_time < generation.data[0].end_time
@@ -536,7 +536,7 @@ def test_openai_completion():
536536
assert completion.choices[0].text == generation.data[0].output
537537
assert generation.data[0].input == "1 + 1 = "
538538
assert generation.data[0].type == "GENERATION"
539-
assert generation.data[0].model == "gpt-3.5-turbo-instruct"
539+
assert "gpt-3.5-turbo-instruct" in generation.data[0].model
540540
assert generation.data[0].start_time is not None
541541
assert generation.data[0].end_time is not None
542542
assert generation.data[0].start_time < generation.data[0].end_time
@@ -587,7 +587,7 @@ def test_openai_completion_stream():
587587

588588
assert generation.data[0].input == "1 + 1 = "
589589
assert generation.data[0].type == "GENERATION"
590-
assert generation.data[0].model == "gpt-3.5-turbo-instruct"
590+
assert "gpt-3.5-turbo-instruct" in generation.data[0].model
591591
assert generation.data[0].start_time is not None
592592
assert generation.data[0].end_time is not None
593593
assert generation.data[0].start_time < generation.data[0].end_time

0 commit comments

Comments
 (0)