Closed
Conversation
Contributor
There was a problem hiding this comment.
LGTM
8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
hassiebp
reviewed
Apr 8, 2025
hassiebp
reviewed
Apr 8, 2025
hassiebp
approved these changes
Apr 8, 2025
Contributor
hassiebp
left a comment
There was a problem hiding this comment.
Thanks @davidmc971 - looks good to me, left to minor comments :)
Author
|
Great, thank you! Will implement those shortly :) |
Author
|
Just FYI, these failing tests are expected: There was no OSS release of the server changes yet, such that these test suites are failing because the backend doesn't handle metadata for them. Locally the tests were confirmed to be working. |
Contributor
|
Thanks again @davidmc971 - we have added this in our latest Python SDK v3 release 🙏🏾 |
auto-merge was automatically disabled
July 15, 2025 08:45
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add optional
metadatafield to score-related models and methods for enhanced contextual data support.metadatafield toScoreBodyinscore_body.py.metadatafield toCreateScoreRequestincreate_score_request.pyandBaseScoreinbase_score.py.metadatafield toScore_Numeric,Score_Categorical, andScore_Booleaninscore.py.metadatafield to responses inget_scores_response_data.py.score()function inclient.pyto includemetadataparameter.test_core_sdk.pyto includemetadatain score creation and validation.This description was created by
for 876ecec. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
This PR uniformly introduces an optional metadata field across score-related models and methods for enhanced contextual data support.
/langfuse/api/resources/ingestion/types/score_body.py./langfuse/api/resources/score/types/create_score_request.pyand BaseScore in/langfuse/api/resources/commons/types/base_score.py./langfuse/api/resources/commons/types/score.pyand responses in/langfuse/api/resources/score/types/get_scores_response_data.py./langfuse/client.pyand corresponding tests in/tests/test_core_sdk.pyto reflect the changes.💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!