fix(langgraph): ignore control flow exceptions in LangChain callback (#1169)#1180
Merged
fix(langgraph): ignore control flow exceptions in LangChain callback (#1169)#1180
Conversation
Co-authored-by: Hassieb Pakzad <68423100+hassiebp@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
LangchainCallbackHandlernow ignoresGraphBubbleUpexceptions inon_chain_error, preventing them from being logged as errors.on_chain_errorinLangchainCallbackHandlernow ignores exceptions of typeGraphBubbleUpfromlanggraph.errors, not logging them as errors.CONTROL_FLOW_EXCEPTION_TYPESset to store exception types to be ignored.SetandTypeto imports inlangchain.py.GraphBubbleUpfromlanggraph.errorsand adds it toCONTROL_FLOW_EXCEPTION_TYPESif available.This description was created by
for a43ebe7. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Enhanced LangChain callback handler to properly handle control flow exceptions from LangGraph, preventing GraphBubbleUp exceptions from being logged as errors in Langfuse.
CONTROL_FLOW_EXCEPTION_TYPESset inlangfuse/callback/langchain.pyto track special exception typesGraphBubbleUpexception in control flow handling