Conversation
Contributor
There was a problem hiding this comment.
2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Standardizes API request timeouts to 5 seconds across the Langfuse Python SDK, introducing
LANGFUSE_TIMEOUTfor configuration.langfuse/_client/client.pyfor client, media resolution, and prompt fetching.LANGFUSE_TIMEOUTenvironment variable inlangfuse/_client/environment_variables.pyfor timeout configuration.test_get_expired_prompt_when_failing_fetchintests/test_prompt.pyto reflect new timeout behavior.This description was created by
for a49fc96. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Standardizes API request timeouts to 5 seconds across the Langfuse Python SDK, introducing
LANGFUSE_TIMEOUTenvironment variable for configuration.langfuse/_client/environment_variables.pyto add newLANGFUSE_TIMEOUTenvironment variablelangfuse/_client/client.pyfrom 10-30s to 5s for client, media resolution, and prompt fetching