Merged
Conversation
Contributor
There was a problem hiding this comment.
LGTM
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fix
_url_encodemethod inclient.pyto escape slashes, ensuring correct URL encoding for prompts in folders._url_encodemethod inclient.pyto escape slashes by settingsafe=""inurllib.parse.quote.This description was created by
for f8772e3. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Fixed URL encoding in the Python client to properly handle slashes by modifying
_url_encodemethod inlangfuse/_client/client.pyto useurllib.parse.quote()withsafe=""parameter.