Skip to content

fix(client): use tracing_enabled in get_client #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 2 commits into from
Jun 23, 2025
Merged

fix(client): use tracing_enabled in get_client #1220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ac7709
fix(client): use tracing_enabled in get_client
hassiebp Jun 23, 2025
2d1cec6
fix test
hassiebp Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions langfuse/_client/get_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ def get_client(*, public_key: Optional[str] = None) -> Langfuse:
public_key=instance.public_key,
secret_key=instance.secret_key,
host=instance.host,
tracing_enabled=instance.tracing_enabled,
)

else:
Expand Down Expand Up @@ -94,4 +95,5 @@ def get_client(*, public_key: Optional[str] = None) -> Langfuse:
public_key=public_key,
secret_key=instance.secret_key,
host=instance.host,
tracing_enabled=instance.tracing_enabled,
)
5 changes: 4 additions & 1 deletion langfuse/_client/resource_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ def __new__(
media_upload_thread_count=media_upload_thread_count,
sample_rate=sample_rate,
mask=mask,
tracing_enabled=tracing_enabled if tracing_enabled is not None else True,
tracing_enabled=tracing_enabled
if tracing_enabled is not None
else True,
)

cls._instances[public_key] = instance
Expand All @@ -140,6 +142,7 @@ def _initialize_instance(
):
self.public_key = public_key
self.secret_key = secret_key
self.tracing_enabled = tracing_enabled
self.host = host
self.mask = mask

Expand Down
Loading