Skip to content

Fix async generator case in decorator #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kouk wants to merge 5 commits into from
Closed

Fix async generator case in decorator #1233

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
385859d
Fix async generator case in decorator
kouk Jun 30, 2025
2e03b03
fixup
kouk Jul 1, 2025
29d70e8
Merge branch 'main' into patch-1
kouk Jul 3, 2025
262a1a0
Merge branch 'main' into patch-1
kouk Jul 7, 2025
974c0e2
Merge branch 'main' into patch-1
kouk Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions langfuse/_client/observe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import asyncio
import inspect
import logging
import os
Expand Down Expand Up @@ -169,7 +168,7 @@ def decorator(func: F) -> F:
capture_output=should_capture_output,
transform_to_string=transform_to_string,
)
if asyncio.iscoroutinefunction(func)
if inspect.iscoroutinefunction(func)
else self._sync_observe(
func,
name=name,
Expand Down Expand Up @@ -355,6 +354,14 @@ def sync_wrapper(*args, **kwargs):
result,
transform_to_string,
)
elif inspect.isasyncgen(result):
is_return_type_generator = True

return self._wrap_async_generator_result(
langfuse_span_or_generation,
result,
transform_to_string,
)

langfuse_span_or_generation.update(output=result)

Expand Down