Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: Experimental PR review
Greptile Summary
This PR addresses how the langfuse Python SDK handles NaN (Not a Number) values during JSON serialization. The change modifies the
EventSerializerclass to serialize NaN values as the string "NaN" instead ofNone. This is a small but important change that improves consistency in how numerical edge cases are handled, particularly aligning with JavaScript's JSON handling and matching the existing behavior for infinity values in the codebase.The change is implemented by adding a specific check for NaN float values using
math.isnan()and returning the string "NaN" instead of the previous implicitNoneconversion. This modification helps maintain semantic clarity sinceNoneandNaNhave distinct meanings in programming contexts.Confidence score: 4/5
langfuse/_utils/serializer.py- verify this doesn't break any existing consumers expectingNonevalues1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Important
Change serialization of
NaNvalues fromNoneto "NaN" indefault()method ofEventSerializer.NaNvalues fromNoneto "NaN" indefault()method ofEventSerializerinserializer.py.This description was created by
for 4c533e0. You can customize this summary. It will automatically update as commits are pushed.