chore: update default value docs for FLUSH_AT and FLUSH_INTERVAL#1306
Merged
hassiebp merged 2 commits intolangfuse:mainfrom Aug 25, 2025
Merged
chore: update default value docs for FLUSH_AT and FLUSH_INTERVAL#1306hassiebp merged 2 commits intolangfuse:mainfrom
FLUSH_AT and FLUSH_INTERVAL#1306hassiebp merged 2 commits intolangfuse:mainfrom
Conversation
Signed-off-by: qnnn <qiunan@cmbchina.com>
FLUSH_AT and FLUSH_INTERVALFLUSH_AT and FLUSH_INTERVAL
Contributor
|
Thanks for your contribution, @qnnn ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I found that the current default values of
LANGFUSE_FLUSH_ATandLANGFUSE_FLUSH_INTERVALdo not match the documentation comments.So I updated the docs to align the default values according to the changes in #1229.
Important
Update default value documentation for
LANGFUSE_FLUSH_ATandLANGFUSE_FLUSH_INTERVALinenvironment_variables.pyto align with OpenTelemetry constants.LANGFUSE_FLUSH_ATto "same as OTELOTEL_BSP_MAX_EXPORT_BATCH_SIZE" inenvironment_variables.py.LANGFUSE_FLUSH_INTERVALto "same as OTELOTEL_BSP_SCHEDULE_DELAY" inenvironment_variables.py.This description was created by
for c3c05d2. You can customize this summary. It will automatically update as commits are pushed.
Disclaimer: Experimental PR review
Greptile Summary
This PR fixes documentation inconsistencies in the environment variables configuration file. Specifically, it updates the default value documentation for two environment variables:
LANGFUSE_FLUSH_ATandLANGFUSE_FLUSH_INTERVAL.The changes align the documentation with the actual implementation that was modified in PR #1229. Previously, the documentation incorrectly stated hardcoded default values (15 for flush_at and 1 second for flush_interval). However, the actual implementation now uses OpenTelemetry's native BatchSpanProcessor defaults when these environment variables are not explicitly set.
The updated documentation now correctly references:
OTEL_BSP_MAX_EXPORT_BATCH_SIZE(default: 512) forLANGFUSE_FLUSH_ATOTEL_BSP_SCHEDULE_DELAY(default: 5000ms/5 seconds) forLANGFUSE_FLUSH_INTERVALThis change ensures that developers reading the documentation will have accurate information about the actual runtime behavior of these configuration options. The fix is purely documentation-focused and maintains consistency between the codebase implementation and its documentation.
Confidence score: 5/5