Skip to content

fix: handle non-ASCII URLs and false positives in external link checker#740

Merged
RiskeyL merged 1 commit into
mainfrom
fix/link-checker-non-ascii-urls
Apr 10, 2026
Merged

fix: handle non-ASCII URLs and false positives in external link checker#740
RiskeyL merged 1 commit into
mainfrom
fix/link-checker-non-ascii-urls

Conversation

@RiskeyL
Copy link
Copy Markdown
Contributor

@RiskeyL RiskeyL commented Apr 10, 2026

Summary

  • Fix link checker crash on URLs with CJK characters (e.g. translated API reference paths) by URL-encoding non-ASCII characters before making requests
  • Skip domains that reliably produce false positives from GitHub runners: volcengine.com (geo-restricted), twitter.com/x.com (blocks automated requests)
  • Update actions/checkout from v4 to v5 to resolve Node.js 20 deprecation warning
  • Fix malformed image URL in ja/use-dify/tutorials/build-ai-image-generation-app.mdx (missing closing quote)

Copilot AI review requested due to automatic review settings April 10, 2026 04:47
@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented Apr 10, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
dify-core-product 🟢 Ready View Preview Apr 10, 2026, 4:50 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 10, 2026
@dosubot dosubot Bot added the bug Something isn't working label Apr 10, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the documentation external link checker to be more resilient (non-ASCII URL handling and fewer runner-induced false positives), adjusts the scheduled link-check workflow, and fixes a malformed image URL in Japanese docs.

Changes:

  • URL-encode non-ASCII characters before making external link requests, and skip a small set of domains that are consistently unreliable from CI.
  • Update the external-link-check GitHub Actions workflow to use actions/checkout@v5.
  • Fix a malformed src="..." string in ja/use-dify/tutorials/build-ai-image-generation-app.mdx.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
tools/check-links.py Adds URL path encoding and expands domain skipping for external link checks.
.github/workflows/check_external_links.yml Bumps actions/checkout to v5 for the scheduled external link check workflow.
ja/use-dify/tutorials/build-ai-image-generation-app.mdx Fixes a broken image URL string in the Japanese tutorial.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/check-links.py Outdated
Comment thread tools/check-links.py Outdated
Comment thread tools/check-links.py Outdated
Comment thread tools/check-links.py
Comment thread ja/use-dify/tutorials/build-ai-image-generation-app.mdx Outdated
Comment thread .github/workflows/check_external_links.yml
@RiskeyL RiskeyL force-pushed the fix/link-checker-non-ascii-urls branch from f0f97e6 to 5233751 Compare April 10, 2026 05:07
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 10, 2026
@RiskeyL RiskeyL merged commit 7296066 into main Apr 10, 2026
2 of 3 checks passed
@RiskeyL RiskeyL deleted the fix/link-checker-non-ascii-urls branch April 10, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants