fix: handle non-ASCII URLs and false positives in external link checker#740
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the documentation external link checker to be more resilient (non-ASCII URL handling and fewer runner-induced false positives), adjusts the scheduled link-check workflow, and fixes a malformed image URL in Japanese docs.
Changes:
- URL-encode non-ASCII characters before making external link requests, and skip a small set of domains that are consistently unreliable from CI.
- Update the external-link-check GitHub Actions workflow to use
actions/checkout@v5. - Fix a malformed
src="..."string inja/use-dify/tutorials/build-ai-image-generation-app.mdx.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tools/check-links.py | Adds URL path encoding and expands domain skipping for external link checks. |
| .github/workflows/check_external_links.yml | Bumps actions/checkout to v5 for the scheduled external link check workflow. |
| ja/use-dify/tutorials/build-ai-image-generation-app.mdx | Fixes a broken image URL string in the Japanese tutorial. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f0f97e6 to
5233751
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutfrom v4 to v5 to resolve Node.js 20 deprecation warningja/use-dify/tutorials/build-ai-image-generation-app.mdx(missing closing quote)