Skip to content

style: drop trailing-whitespace and callout-blank-line format rules#771

Merged
RiskeyL merged 1 commit into
mainfrom
style/remove-whitespacing-rule
Apr 30, 2026
Merged

style: drop trailing-whitespace and callout-blank-line format rules#771
RiskeyL merged 1 commit into
mainfrom
style/remove-whitespacing-rule

Conversation

@RiskeyL
Copy link
Copy Markdown
Contributor

@RiskeyL RiskeyL commented Apr 30, 2026

Summary

  • Drop S-trailing-whitespace and M-component-blank-before / M-component-blank-after from both format-check linters (check-format-en.py, check-format-cjk.py) and their SKILL.md rule indices.
  • Remove the matching prose from writing-guides/formatting-guide.md: the per-callout "one blank line before and after the component" line and the before/after components clause in the general Spacing rule.

Copilot AI review requested due to automatic review settings April 30, 2026 03:34
@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented Apr 30, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
dify-core-product 🟢 Ready View Preview Apr 30, 2026, 3:36 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation labels Apr 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the documentation formatting rules and their deterministic linters by removing enforcement of trailing-whitespace checks and “blank line before/after Mintlify callouts” checks, aligning the prose guide and both EN/CJK format-check skills.

Changes:

  • Remove the “one blank line before/after callout component” requirement from the formatting guide.
  • Delete Mintlify callout surrounding-blank-line violations (M-component-blank-before/after) from both EN and CJK format-check linters and their SKILL rule indices.
  • Drop trailing-whitespace detection (S-trailing-whitespace) from both EN and CJK format-check linters and their SKILL rule indices.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
writing-guides/formatting-guide.md Removes callout blank-line requirement and updates the general spacing rule accordingly.
.claude/skills/dify-docs-format-check-en/check-format-en.py Removes M-component-blank-before/after callout checks and S-trailing-whitespace detection from the EN linter.
.claude/skills/dify-docs-format-check-en/SKILL.md Removes the deleted rule IDs from the EN skill’s documented rule list.
.claude/skills/dify-docs-format-check-cjk/check-format-cjk.py Removes callout blank-line checks and trailing-whitespace detection from the CJK linter.
.claude/skills/dify-docs-format-check-cjk/SKILL.md Removes the deleted rule IDs from the CJK skill’s documented rule list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RiskeyL RiskeyL merged commit 604bdb8 into main Apr 30, 2026
5 checks passed
@RiskeyL RiskeyL deleted the style/remove-whitespacing-rule branch April 30, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants