fix: fix lru miss init (#622)

* fix: fix lru miss init

* fix: gemini review

---------

Co-authored-by: Stream <Stream_2@qq.com>

Author: fatelei

.env.example

@@ -65,6 +65,8 @@ PLUGIN_INSTALLED_PATH=plugin
 # where the plugin finally running and working
 PLUGIN_WORKING_PATH=cwd
 
+PLUGIN_ASSET_CACHE_SIZE=256
+
 # persistence storage
 PERSISTENCE_STORAGE_PATH=persistence
 PERSISTENCE_STORAGE_MAX_SIZE=104857600

internal/core/plugin_manager/manager.go

@@ -42,6 +42,8 @@ type PluginManager struct {
 
 	config *app.Config
 
+	pluginAssetCache *lru.Cache[string, []byte]
+
 	// plugin lifecycle controller
 	//
 	// whatever it's local mode or serverless mode, all the signals and calls
@@ -71,10 +73,16 @@ func InitGlobalManager(oss oss.OSS, config *app.Config) *PluginManager {
 		config.PluginPackageCachePath,
 	)
 
+	pluginAssetCache, err := lru.New[string, []byte](int(config.PluginAssetCacheSize))
+	if err != nil {
+		log.Panic("init plugin asset cache failed", "error", err)
+	}
+
 	manager = &PluginManager{
-		mediaBucket:     mediaBucket,
-		packageBucket:   packageBucket,
-		installedBucket: installedBucket,
+		mediaBucket:      mediaBucket,
+		packageBucket:    packageBucket,
+		installedBucket:  installedBucket,
+		pluginAssetCache: pluginAssetCache,
 		controlPanel: controlpanel.NewControlPanel(
 			config,
 			mediaBucket,
@@ -196,26 +204,23 @@ func (c *PluginManager) NeedRedirecting(
 	return true, nil
 }
 
-var (
-	pluginAssetCache *lru.Cache[string, []byte]
-)
-
 func pluginAssetCacheKey(
 	pluginUniqueIdentifier plugin_entities.PluginUniqueIdentifier,
 	path string,
 ) string {
 	return fmt.Sprintf("%s/%s", pluginUniqueIdentifier.String(), path)
 }
+
 func (p *PluginManager) ExtractPluginAsset(
 	pluginUniqueIdentifier plugin_entities.PluginUniqueIdentifier,
 	path string,
 ) ([]byte, error) {
 	key := pluginAssetCacheKey(pluginUniqueIdentifier, path)
-	cached, ok := pluginAssetCache.Get(key)
+	cached, ok := p.pluginAssetCache.Get(key)
 	if ok {
 		return cached, nil
 	}
-	pkgBytes, err := manager.GetPackage(pluginUniqueIdentifier)
+	pkgBytes, err := p.GetPackage(pluginUniqueIdentifier)
 	if err != nil {
 		return nil, err
 	}
@@ -227,6 +232,6 @@ func (p *PluginManager) ExtractPluginAsset(
 	if err != nil {
 		return nil, err
 	}
-	pluginAssetCache.Add(key, assets[path])
+	p.pluginAssetCache.Add(key, assets[path])
 	return assets[path], nil
 }

internal/types/app/config.go

@@ -97,6 +97,7 @@ type Config struct {
 
 	PluginWorkingPath      string `envconfig:"PLUGIN_WORKING_PATH"` // where the plugin finally running
 	PluginMediaCacheSize   uint16 `envconfig:"PLUGIN_MEDIA_CACHE_SIZE"`
+	PluginAssetCacheSize   uint16 `envconfig:"PLUGIN_ASSET_CACHE_SIZE"`
 	PluginMediaCachePath   string `envconfig:"PLUGIN_MEDIA_CACHE_PATH"`
 	PluginInstalledPath    string `envconfig:"PLUGIN_INSTALLED_PATH" validate:"required"` // where the plugin finally installed
 	PluginPackageCachePath string `envconfig:"PLUGIN_PACKAGE_CACHE_PATH"`                 // where plugin packages stored

internal/types/app/default.go

@@ -25,6 +25,7 @@ func (config *Config) SetDefault() {
 	setDefaultInt(&config.PluginMaxExecutionTimeout, 10*60)
 	setDefaultString(&config.PluginStorageType, oss.OSS_TYPE_LOCAL)
 	setDefaultInt(&config.PluginMediaCacheSize, 1024)
+	setDefaultInt(&config.PluginAssetCacheSize, 256)
 	setDefaultInt(&config.DifyPluginServerlessConnectorLaunchTimeout, 240)
 	setDefaultInt(&config.PluginRemoteInstallingMaxSingleTenantConn, 5)
 	setDefaultString(&config.DBSslMode, "disable")