fix: plugin log not display after refactor (#537)

* fix: plugin log not display after refactor

* Update internal/core/local_runtime/notifier_logger.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* feat: add logging support for local runtime instance events

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Yeuoly <admin@srmxy.cn>

Author: 3 people

internal/core/control_panel/launcher_local.go

@@ -132,6 +132,11 @@ func (c *ControlPanel) LaunchLocalPlugin(
 				notifier.OnLocalRuntimeStop(runtime)
 			})
 		},
+		OnInstanceLogImpl: func(pi *local_runtime.PluginInstance, ple plugin_entities.PluginLogEvent) {
+			c.WalkNotifiers(func(notifier ControlPanelNotifier) {
+				notifier.OnLocalRuntimeInstanceLog(runtime, pi, ple)
+			})
+		},
 	}
 	runtime.AddNotifier(lifetime)
 

internal/core/control_panel/logger.go

@@ -1,6 +1,8 @@
 package controlpanel
 
 import (
+	"strings"
+
 	"github.com/langgenius/dify-plugin-daemon/internal/core/debugging_runtime"
 	"github.com/langgenius/dify-plugin-daemon/internal/core/local_runtime"
 	"github.com/langgenius/dify-plugin-daemon/pkg/entities/plugin_entities"
@@ -32,6 +34,33 @@ func (l *StandardLogger) OnLocalRuntimeStopped(runtime *local_runtime.LocalPlugi
 	log.Info("local runtime stopped: %s", identity)
 }
 
+var (
+	loggers = map[string]func(string, ...interface{}){
+		"debug":    log.Debug,
+		"warn":     log.Warn,
+		"warning":  log.Warn,
+		"error":    log.Error,
+		"fatal":    log.Error,
+		"critical": log.Error,
+	}
+)
+
+func (l *StandardLogger) OnLocalRuntimeInstanceLog(
+	runtime *local_runtime.LocalPluginRuntime,
+	instance *local_runtime.PluginInstance,
+	event plugin_entities.PluginLogEvent,
+) {
+	// notify terminal
+	instanceID := instance.ID()[:8]
+	loggerFunc, ok := loggers[strings.ToLower(event.Level)]
+	if !ok {
+		loggerFunc = log.Info
+	}
+	identity, _ := runtime.Identity()
+
+	loggerFunc("plugin %s: instance %s log: %s", identity, instanceID, event.Message)
+}
+
 func (l *StandardLogger) OnDebuggingRuntimeConnected(runtime *debugging_runtime.RemotePluginRuntime) {
 	identity, _ := runtime.Identity()
 	log.Info("debugging runtime connected: %s", identity)

internal/core/control_panel/signals.go

@@ -21,6 +21,12 @@ type ControlPanelNotifier interface {
 	OnLocalRuntimeScaleUp(runtime *local_runtime.LocalPluginRuntime, instanceNums int32)
 	// on local runtime scale down
 	OnLocalRuntimeScaleDown(runtime *local_runtime.LocalPluginRuntime, instanceNums int32)
+	// on local runtime instance log
+	OnLocalRuntimeInstanceLog(
+		runtime *local_runtime.LocalPluginRuntime,
+		instance *local_runtime.PluginInstance,
+		event plugin_entities.PluginLogEvent,
+	)
 
 	// on remote runtime connected
 	OnDebuggingRuntimeConnected(runtime *debugging_runtime.RemotePluginRuntime)

internal/core/debugging_runtime/lifetime.go

@@ -47,9 +47,7 @@ func (r *RemotePluginRuntime) SpawnCore() error {
 			func(err string) {
 				log.Error("plugin %s: %s", r.Configuration().Identity(), err)
 			},
-			func(message string) {
-				log.Info("plugin %s: %s", r.Configuration().Identity(), message)
-			},
+			func(plugin_entities.PluginLogEvent) {}, // remote debugging logs stay on client side
 		)
 	})
 

internal/core/io_tunnel/backwards_invocation/transaction/aws_event_handler.go

@@ -116,7 +116,7 @@ func (h *ServerlessTransactionHandler) Handle(
 		func(err string) {
 			log.Warn("invoke dify failed, received errors: %s", err)
 		},
-		func(message string) {}, //log
+		func(plugin_entities.PluginLogEvent) {}, //log
 	)
 
 	select {

internal/core/local_runtime/instance.go

@@ -201,10 +201,10 @@ func (s *PluginInstance) handleStdout(data []byte, once *sync.Once) {
 				notifier.OnInstanceErrorLog(s, errors.New(err))
 			})
 		},
-		func(message string) {
+		func(logEvent plugin_entities.PluginLogEvent) {
 			// plain text log
 			s.WalkNotifiers(func(notifier PluginInstanceNotifier) {
-				notifier.OnInstanceLog(s, message)
+				notifier.OnInstanceLog(s, logEvent)
 			})
 		},
 	)
@@ -330,3 +330,7 @@ func (s *PluginInstance) GracefulStop(maxWaitTime time.Duration) {
 	// all listeners are closed, stop the instance
 	s.Stop()
 }
+
+func (s *PluginInstance) ID() string {
+	return s.instanceId
+}

internal/core/local_runtime/notifier_lifecycle.go

@@ -2,6 +2,8 @@ package local_runtime
 
 import (
 	"time"
+
+	"github.com/langgenius/dify-plugin-daemon/pkg/entities/plugin_entities"
 )
 
 type NotifierHeartbeat struct {
@@ -41,7 +43,7 @@ func (n *NotifierHeartbeat) OnInstanceHeartbeat(instance *PluginInstance) {
 	instance.lastActiveAt = time.Now()
 }
 
-func (n *NotifierHeartbeat) OnInstanceLog(instance *PluginInstance, message string) {
+func (n *NotifierHeartbeat) OnInstanceLog(instance *PluginInstance, event plugin_entities.PluginLogEvent) {
 
 }
 

internal/core/local_runtime/notifier_logger.go

@@ -1,5 +1,7 @@
 package local_runtime
 
+import "github.com/langgenius/dify-plugin-daemon/pkg/entities/plugin_entities"
+
 type InstanceSignal string
 
 const (
@@ -47,7 +49,7 @@ type PluginInstanceNotifier interface {
 	OnInstanceHeartbeat(*PluginInstance)
 
 	// on instance log
-	OnInstanceLog(*PluginInstance, string)
+	OnInstanceLog(*PluginInstance, plugin_entities.PluginLogEvent)
 
 	// on instance error
 	OnInstanceErrorLog(*PluginInstance, error)

internal/core/local_runtime/signals_instance.go

@@ -1,5 +1,7 @@
 package local_runtime
 
+import "github.com/langgenius/dify-plugin-daemon/pkg/entities/plugin_entities"
+
 type PluginRuntimeNotifier interface {
 	// on instance starting
 	OnInstanceStarting()
@@ -13,6 +15,9 @@ type PluginRuntimeNotifier interface {
 	// on instance shutdown
 	OnInstanceShutdown(*PluginInstance)
 
+	// on instance log
+	OnInstanceLog(*PluginInstance, plugin_entities.PluginLogEvent)
+
 	// on instance scale up
 	OnInstanceScaleUp(int32)