Revert "feat: install plugin api add optional current task response"

This reverts commit bf16b52.

Author: hjlarry

internal/service/install_plugin.go

@@ -27,9 +27,8 @@ import (
 )
 
 type InstallPluginResponse struct {
-	AllInstalled bool                `json:"all_installed"`
-	TaskID       string              `json:"task_id"`
-	Task         *models.InstallTask `json:"task,omitempty"`
+	AllInstalled bool   `json:"all_installed"`
+	TaskID       string `json:"task_id"`
 }
 
 // Dify supports install multiple plugins to a tenant at once
@@ -143,7 +142,6 @@ func InstallMultiplePluginsToTenant(
 		// EE edition reference task should not be the first one
 		// here we use `PrimaryID` to present the user-facing task id
 		TaskID: taskRegistry.PrimaryID(),
-		Task:   taskRegistry.PrimaryTask(),
 	})
 }
 
@@ -320,7 +318,6 @@ func UpgradePlugin(
 	return entities.NewSuccessResponse(&InstallPluginResponse{
 		AllInstalled: false,
 		TaskID:       taskRegistry.PrimaryID(),
-		Task:         taskRegistry.PrimaryTask(),
 	})
 }
 

internal/service/install_plugin_test.go

@@ -5,57 +5,9 @@ import (
 	"testing"
 
 	"github.com/langgenius/dify-plugin-daemon/internal/types/app"
-	"github.com/langgenius/dify-plugin-daemon/internal/types/models"
 	"github.com/langgenius/dify-plugin-daemon/pkg/entities/plugin_entities"
 )
 
-func TestInstallPluginResponseIncludesPrimaryTask(t *testing.T) {
-	setupTestDB(t)
-
-	identifier, err := plugin_entities.NewPluginUniqueIdentifier("author/test-plugin:1.0.0@abcdef1234567890abcdef1234567890ab")
-	if err != nil {
-		t.Fatalf("failed to create plugin unique identifier: %v", err)
-	}
-
-	taskRegistry, err := createInstallTasks([]string{"tenant-123"}, []models.InstallTaskPluginStatus{
-		{
-			PluginUniqueIdentifier: identifier,
-			PluginID:               identifier.PluginID(),
-			Status:                 models.InstallTaskStatusPending,
-			Source:                 "marketplace",
-		},
-	})
-	if err != nil {
-		t.Fatalf("failed to create install task: %v", err)
-	}
-
-	response := InstallPluginResponse{
-		AllInstalled: false,
-		TaskID:       taskRegistry.PrimaryID(),
-		Task:         taskRegistry.PrimaryTask(),
-	}
-
-	data, err := json.Marshal(response)
-	if err != nil {
-		t.Fatalf("failed to marshal response: %v", err)
-	}
-
-	var decoded InstallPluginResponse
-	if err := json.Unmarshal(data, &decoded); err != nil {
-		t.Fatalf("failed to unmarshal response: %v", err)
-	}
-
-	if decoded.Task == nil {
-		t.Fatal("expected response task to be present")
-	}
-	if decoded.TaskID == "" {
-		t.Fatal("expected response task_id to be present")
-	}
-	if decoded.Task.ID != decoded.TaskID {
-		t.Fatalf("task id mismatch: got %s, want %s", decoded.Task.ID, decoded.TaskID)
-	}
-}
-
 func TestUpgradePlugin(t *testing.T) {
 	originalIdentifier, err := plugin_entities.NewPluginUniqueIdentifier("author/test-plugin:1.0.0@abcdef1234567890abcdef1234567890ab")
 	if err != nil {
@@ -72,32 +24,32 @@ func TestUpgradePlugin(t *testing.T) {
 	}
 
 	tests := []struct {
-		name                           string
-		tenantId                       string
-		source                         string
-		meta                           map[string]any
-		originalPluginUniqueIdentifier plugin_entities.PluginUniqueIdentifier
-		newPluginUniqueIdentifier      plugin_entities.PluginUniqueIdentifier
-		wantSuccess                    bool
-		wantAllInstalled               bool
-		wantTaskIDEmpty                bool
+		name                             string
+		tenantId                         string
+		source                           string
+		meta                             map[string]any
+		originalPluginUniqueIdentifier   plugin_entities.PluginUniqueIdentifier
+		newPluginUniqueIdentifier        plugin_entities.PluginUniqueIdentifier
+		wantSuccess                      bool
+		wantAllInstalled                 bool
+		wantTaskIDEmpty                  bool
 	}{
 		{
 			name:                           "same plugin identifiers",
 			tenantId:                       "tenant-123",
 			source:                         "test",
 			meta:                           map[string]any{},
-			originalPluginUniqueIdentifier: originalIdentifier,
-			newPluginUniqueIdentifier:      originalIdentifier,
+			originalPluginUniqueIdentifier:  originalIdentifier,
+			newPluginUniqueIdentifier:       originalIdentifier,
 			wantSuccess:                    false,
 		},
 		{
 			name:                           "different plugin identifiers",
 			tenantId:                       "tenant-123",
 			source:                         "test",
 			meta:                           map[string]any{},
-			originalPluginUniqueIdentifier: originalIdentifier,
-			newPluginUniqueIdentifier:      newIdentifier,
+			originalPluginUniqueIdentifier:  originalIdentifier,
+			newPluginUniqueIdentifier:       newIdentifier,
 			wantSuccess:                    false,
 		},
 	}

internal/tasks/install_plugin_utils.go

@@ -29,21 +29,13 @@ func (r *InstallTaskRegistry) IDs() []string {
 }
 
 func (r *InstallTaskRegistry) PrimaryID() string {
-	task := r.PrimaryTask()
-	if task == nil {
-		return ""
-	}
-	return task.ID
-}
-
-func (r *InstallTaskRegistry) PrimaryTask() *models.InstallTask {
 	if len(r.Order) == 0 {
-		return nil
+		return ""
 	}
 	if task, ok := r.Tasks[r.Order[0]]; ok {
-		return task
+		return task.ID
 	}
-	return nil
+	return ""
 }
 
 func truncateMessage(message string) string {