feat: prioritize pyproject.toml when installing plugin dependencies#557
Conversation
Summary of ChangesHello @Stream29, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to how Python plugin dependencies are managed by adding support for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for pyproject.toml as a primary dependency management file for Python plugins, prioritizing it over requirements.txt. The changes include adding new functions to detect the dependency file type (pyproject.toml or requirements.txt), prepare arguments for uv sync (for pyproject.toml) and uv pip install (for requirements.txt), and modify existing functions like InitPythonEnvironment and patchPluginSdk to utilize this new detection logic. Comprehensive unit and integration tests have been added to validate these changes, covering scenarios with pyproject.toml only, requirements.txt only, both files (with pyproject.toml taking precedence), and no dependency files. Review feedback suggests renaming a parameter in getPluginSdkVersion for clarity, improving the robustness of PipExtraArgs parsing in prepareSyncArgs and preparePipArgs to handle spaces in arguments, and optimizing file system access by reducing redundant calls to detectDependencyFileType.
…e and requirementsTxtFile
|
@Yeuoly Thank you for your detailed review and suggestions. I will improve my code quality. |
Description
Accept and prioritize
pyproject.tomlwhen installing plugin dependencies.Type of Change
Essential Checklist
Testing
Additional Information
Please provide any additional context that would help reviewers understand the changes.