fix: concurrent map iteration and map write

[fatelei]

Description

fix #292

because gojsonschema.NewGoLoader(schema), inside will use schema(map/slice) to do iteration, when share schema in mul goroutine will lead concurrent map iteration and map write

Type of Change

• Bug fix
• New feature
• Refactor
• Performance improvement
• Other

Essential Checklist

Testing

• I have tested the changes locally and confirmed they work as expected
• I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

• I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

[gemini-code-assist]

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical concurrency issue within the JSON schema validation logic. Previously, sharing Go map-based schemas across multiple goroutines could lead to runtime panics due to concurrent map iteration and writes. The fix involves serializing the schema and document to JSON bytes before validation, effectively creating immutable copies for the gojsonschema library to process. This ensures thread safety and prevents race conditions, enhancing the robustness of the application's schema validation capabilities. New utility functions and a dedicated test case have been added to support and verify this change.

Highlights

• Concurrency Bug Fix: Addressed a critical bug where concurrent map iteration and write panics could occur when using gojsonschema.NewGoLoader with shared schema maps in multiple goroutines.
• Immutable Schema Loading: Modified GenerateValidateJson to serialize the input schema to JSON bytes before loading it into gojsonschema using NewBytesLoader, ensuring an immutable copy is used for validation.
• New Validation Utilities: Introduced a new validate.go file with ValidateBytes and Validate functions, providing a safer, concurrent-friendly way to validate JSON schemas and documents by marshaling them to bytes.
• Concurrent Safety Test: Added TestValidateConcurrentSafety to explicitly verify that the new validation functions correctly handle concurrent map access without panicking.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively resolves a concurrent map access issue by marshaling the map to a JSON byte slice before passing it to the gojsonschema library. This is a solid approach to prevent race conditions. The introduction of the Validate and ValidateBytes helper functions in a new validate.go file is a good addition, centralizing the concurrency-safe validation logic. The new concurrency test is also a great way to ensure the fix works and prevent future regressions. My review includes a couple of suggestions to make this new test even more robust.

[Yeuoly]

Can you reproduce this issue in version 0.5.2 ? it should already been fixed after a refactoring at about 3 months ago.

[fatelei]

xeipuuv/gojsonschema v1.2.0 has been fixed