Skip to content

fix: fix lru miss init#622

Merged
fatelei merged 2 commits into
langgenius:mainfrom
fatelei:issue-621
Mar 4, 2026
Merged

fix: fix lru miss init#622
fatelei merged 2 commits into
langgenius:mainfrom
fatelei:issue-621

Conversation

@fatelei

@fatelei fatelei commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Description

fix #621

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

before

Screen.Recording.2026-03-04.at.11.54.28.mov

after

Screen.Recording.2026-03-04.at.11.58.40.mov

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 4, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug where the pluginAssetCache LRU cache was not being initialized, potentially leading to runtime errors or unexpected behavior when attempting to use it. By explicitly initializing the cache during package loading, this change ensures the stability and correct functioning of plugin asset management.

Highlights

  • LRU Cache Initialization Fix: The pluginAssetCache LRU cache is now properly initialized using lru.New within an init() function, ensuring it is ready for use when the package is loaded.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • internal/core/plugin_manager/manager.go
    • Initialized the pluginAssetCache LRU cache within an init() function to prevent uninitialized access.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot Bot added bug Something isn't working go Pull requests that update go code plugin-daemon labels Mar 4, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly fixes a nil pointer dereference by initializing pluginAssetCache. However, the current implementation uses a package init function with a hardcoded cache size. This is inconsistent with other configurable caches in the application and makes it difficult to tune. My feedback suggests a refactoring to make the cache part of the PluginManager struct, allowing its size to be configured dynamically and improving the overall design by avoiding global state.

Comment thread internal/core/plugin_manager/manager.go Outdated
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 4, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 4, 2026
@fatelei fatelei merged commit 07815fd into langgenius:main Mar 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update go code lgtm This PR has been approved by a maintainer plugin-daemon size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lru.New miss init lead panic

2 participants