feat: add uv sync offline flag#623
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the plugin management system by introducing an "offline" mode for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces an --offline flag for uv sync to support offline installation of manually uploaded plugins. However, a critical vulnerability has been identified: a mismatch in cache key construction and incompatible cache methods (AutoSet vs Get) prevents the manually_uploaded flag from being correctly detected. This bypasses the intended offline mode, potentially leading to unauthorized network access during plugin installation. Additionally, the cache key has a short, 30-minute expiration which is likely insufficient. Addressing these cache-related issues is crucial for the feature to work as intended and to prevent potential security risks.
f892cd3 to
9bd0af1
Compare
Stream29
left a comment
There was a problem hiding this comment.
We'd better split the formatting into another PR.
ok |
Description
fix #615
use dify package generate bundle plugin, allow not download dep from pypi
Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
Please provide any additional context that would help reviewers understand the changes.