fix: fix old plugin not exit normally#699
Open
fatelei wants to merge 1 commit intolanggenius:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the local plugin shutdown process to ensure subprocesses are correctly terminated and to prevent process leaks. Key changes include moving the runtime deletion to the OnRuntimeCloseImpl callback, introducing the PluginShutdownManager interface, and implementing a timeout-based shutdown sequence in RemovePluginIfNeeded that falls back to a forceful shutdown if the graceful attempt fails. The review feedback identifies opportunities to improve the robustness of this logic by treating 'not found' errors as successes during shutdown attempts, which prevents unnecessary task failures if a plugin has already been cleaned up or finishes shutting down just as a timeout occurs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #698
Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
Please provide any additional context that would help reviewers understand the changes.