Skip to content

perf: make .uv-cache as shared folder#704

Merged
fatelei merged 1 commit into
langgenius:mainfrom
fatelei:issue-703
Apr 22, 2026
Merged

perf: make .uv-cache as shared folder#704
fatelei merged 1 commit into
langgenius:mainfrom
fatelei:issue-703

Conversation

@fatelei

@fatelei fatelei commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Description

fix #703

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. go Pull requests that update go code plugin-daemon labels Apr 22, 2026
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the logic for determining the uv cache directory, allowing for a configurable path or a shared directory under the plugin working path. Feedback identifies a missing field in the configuration struct that will cause a compilation error and suggests converting the cache path to an absolute path to ensure correct resolution during command execution.

Comment thread internal/core/local_runtime/setup_python_environment.go Outdated
Comment thread internal/core/local_runtime/setup_python_environment.go Outdated
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 22, 2026
@fatelei fatelei merged commit d9ed798 into langgenius:main Apr 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update go code lgtm This PR has been approved by a maintainer plugin-daemon size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

increase plugin start speed

2 participants