Skip to content

chore: add debug log#709

Merged
FFXN merged 1 commit into
langgenius:mainfrom
fatelei:debug_log
Apr 24, 2026
Merged

chore: add debug log#709
FFXN merged 1 commit into
langgenius:mainfrom
fatelei:debug_log

Conversation

@fatelei

@fatelei fatelei commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Description

Please provide a brief description of the changes made in this pull request.
Please also include the issue number if this is related to an issue using the format Fixes #123 or Closes #123.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. go Pull requests that update go code plugin-daemon labels Apr 24, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances observability by adding detailed logging for plugin instance lifecycles, including startup, shutdown, and subprocess management. Feedback focuses on addressing potential data races when accessing instance state fields without synchronization. Additionally, several suggestions were made to adjust log levels from warning to info for normal operational events and to ensure consistent use of callback parameters.

Comment thread internal/core/local_runtime/instance.go
Comment thread internal/core/local_runtime/instance.go
Comment thread internal/core/local_runtime/instance.go
Comment thread internal/core/local_runtime/subprocess.go
Comment thread internal/core/local_runtime/subprocess.go Outdated
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 24, 2026
@FFXN FFXN merged commit c06646b into langgenius:main Apr 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update go code lgtm This PR has been approved by a maintainer plugin-daemon size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants