Skip to content

fix: fix remote debug can not redirect#761

Merged
fatelei merged 1 commit into
langgenius:mainfrom
fatelei:remote_debug
Jun 23, 2026
Merged

fix: fix remote debug can not redirect#761
fatelei merged 1 commit into
langgenius:mainfrom
fatelei:remote_debug

Conversation

@fatelei

@fatelei fatelei commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description

because platform is a global config, so it will affect the remote debug plugin

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working plugin-daemon labels Jun 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the NeedRedirecting method in PluginManager to handle remote-like plugin identities by checking their runtime status via the control panel. The review feedback points out that propagating the error when a plugin runtime is not found could mislead callers into treating it as an execution failure. It is recommended to explicitly handle controlpanel.ErrPluginRuntimeNotFound and return true, nil to properly trigger redirection.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread internal/core/plugin_manager/manager.go
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 23, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 23, 2026
@fatelei fatelei merged commit 54432d8 into langgenius:main Jun 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer plugin-daemon size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants