chore: reduce global Ruff ignore list (#326)

Author: WH-2099

examples/agent/strategies/function_calling.py

@@ -537,7 +537,7 @@ def _append_tool_invoke_response_text(
             return
 
         if tool_invoke_response.type == ToolInvokeMessage.MessageType.BLOB:
-            # TODO: convert to agent invoke message
+            # Conversion to an agent invoke message remains open here.
             yield tool_invoke_response
             text_parts.append("Generated file ... ")
             return
@@ -556,7 +556,7 @@ def _handle_image_tool_response(
             ).text
             yield from self._create_image_blob_message(file_info)
 
-        # TODO: convert to agent invoke message
+        # Conversion to an agent invoke message remains open here.
         yield tool_invoke_response
         text_parts.append(
             "image has been created and sent to user already, "

examples/agent/strategies/react.py

@@ -202,7 +202,7 @@ def _invoke(self, parameters: dict[str, Any]) -> Generator[AgentInvokeMessage]:
                 if isinstance(chunk, AgentScratchpadUnit.Action):
                     action = chunk
                     # detect action
-                    assert scratchpad.agent_response is not None
+                    scratchpad.agent_response = scratchpad.agent_response or ""
                     scratchpad.agent_response += json.dumps(chunk.model_dump())
 
                     scratchpad.action_str = json.dumps(chunk.model_dump())
@@ -297,7 +297,7 @@ def _invoke(self, parameters: dict[str, Any]) -> Generator[AgentInvokeMessage]:
                     scratchpad.observation = tool_invoke_response
                     scratchpad.agent_response = tool_invoke_response
 
-                    # TODO: convert to agent invoke message
+                    # Conversion to an agent invoke message remains open here.
                     yield from additional_messages
                     yield self.finish_log_message(
                         log=tool_call_log,
@@ -393,20 +393,18 @@ def _organize_prompt_messages(
             assistant_messages = []
         else:
             assistant_message = AssistantPromptMessage(content="")
+            assistant_content = cast("str", assistant_message.content)
             for unit in agent_scratchpad:
                 if unit.is_final():
-                    assert isinstance(assistant_message.content, str)
-                    assistant_message.content += f"Final Answer: {unit.agent_response}"
+                    assistant_content += f"Final Answer: {unit.agent_response}"
                 else:
-                    assert isinstance(assistant_message.content, str)
-                    assistant_message.content += f"Thought: {unit.thought}\n\n"
+                    assistant_content += f"Thought: {unit.thought}\n\n"
                     if unit.action_str:
-                        assistant_message.content += f"Action: {unit.action_str}\n\n"
+                        assistant_content += f"Action: {unit.action_str}\n\n"
                     if unit.observation:
-                        assistant_message.content += (
-                            f"Observation: {unit.observation}\n\n"
-                        )
+                        assistant_content += f"Observation: {unit.observation}\n\n"
 
+            assistant_message.content = assistant_content
             assistant_messages = [assistant_message]
 
         # query messages

examples/github/provider/github.py

@@ -79,7 +79,7 @@ def _oauth_refresh_credentials(
         """
         del redirect_uri
         del system_credentials
-        # TODO: Implement the refresh credentials logic
+        # Credential refresh is currently a no-op; credentials are returned unchanged.
         return ToolOAuthCredentials(credentials=credentials, expires_at=-1)
 
     def _validate_credentials(self, credentials: dict) -> None:

examples/github_trigger/provider/github.py

@@ -79,6 +79,27 @@
     "deploy_key",
     "watch",
 })
+EVENT_ALIASES = {
+    **dict.fromkeys(SECRET_SCANNING_EVENTS, "secret_scanning"),
+    **dict.fromkeys(REF_CHANGE_EVENTS, "ref_change"),
+}
+UNIFIED_EVENTS = (
+    CORE_EVENTS
+    | REVIEW_AND_CI_EVENTS
+    | BRANCH_PROTECTION_EVENTS
+    | ADDITIONAL_UNIFIED_EVENTS
+    | frozenset({
+        "push",
+        "star",
+        "code_scanning_alert",
+        "commit_comment",
+        "status",
+        "deployment",
+        "dependabot_alert",
+        "repository_vulnerability_alert",
+        "repository_ruleset",
+    })
+)
 
 
 class GithubTrigger(Trigger):
@@ -111,12 +132,7 @@ def _dispatch_trigger_events(
     ) -> list[str]:
         event_type = event_type.lower()
         action: str | None = payload.get("action")
-        # Unified core events (breaking change): issues / issue_comment / pull_request
-        if event_type in CORE_EVENTS:
-            return [event_type]
-
-        # Unified review & CI events (breaking change)
-        if event_type in REVIEW_AND_CI_EVENTS:
+        if event_type in UNIFIED_EVENTS:
             return [event_type]
 
         if event_type in ACTION_SUFFIX_EVENTS:
@@ -125,46 +141,9 @@ def _dispatch_trigger_events(
                 raise TriggerDispatchError(msg)
             return [f"{event_type}_{action}"]
 
-        if event_type == "push":
-            return ["push"]
-
-        if event_type == "star":
-            return ["star"]
-
-        # Unified events without action splitting
-        if event_type == "code_scanning_alert":
-            return ["code_scanning_alert"]
-
-        if event_type in SECRET_SCANNING_EVENTS:
-            return ["secret_scanning"]
-
-        if event_type in REF_CHANGE_EVENTS:
-            return ["ref_change"]
-
-        if event_type == "commit_comment":
-            return ["commit_comment"]
-
-        if event_type == "status":
-            return ["status"]
-
-        if event_type == "deployment":
-            return ["deployment"]
-
-        if event_type == "dependabot_alert":
-            return ["dependabot_alert"]
-
-        if event_type == "repository_vulnerability_alert":
-            return ["repository_vulnerability_alert"]
-
-        if event_type in BRANCH_PROTECTION_EVENTS:
-            return [event_type]
-
-        if event_type == "repository_ruleset":
-            return ["repository_ruleset"]
-
-        # Additional unified GitHub events (breaking change by design)
-        if event_type in ADDITIONAL_UNIFIED_EVENTS:
-            return [event_type]
+        alias = EVENT_ALIASES.get(event_type)
+        if alias:
+            return [alias]
 
         return []
 

examples/gmail_trigger/events/gmail_message_added/gmail_message_added.py

@@ -348,11 +348,7 @@ def _fetch_attachment_content(
         headers: Mapping[str, str],
     ) -> tuple[bytes | None, int | None]:
         if inline_data:
-            try:
-                content = self._decode_base64url(inline_data)
-            except binascii.Error:
-                return None, None
-            return content, len(content)
+            return self._decode_attachment_data(inline_data)
 
         attachment_id = attachment.get("attachmentId")
         if not attachment_id:
@@ -370,7 +366,11 @@ def _fetch_attachment_content(
             return None, None
 
         data = response.json() or {}
-        encoded = data.get("data")
+        return self._decode_attachment_data(data.get("data"), data.get("size"))
+
+    def _decode_attachment_data(
+        self, encoded: str | None, size: int | None = None
+    ) -> tuple[bytes | None, int | None]:
         if not encoded:
             return None, None
 
@@ -379,7 +379,6 @@ def _fetch_attachment_content(
         except binascii.Error:
             return None, None
 
-        size = data.get("size")
         size_value = size if size is not None else len(content)
         return content, size_value
 

examples/notion_datasource/datasources/utils/notion_extractor.py

@@ -9,8 +9,6 @@
     "heading_2": "## ",
     "heading_3": "### ",
 }
-TEXT_PROPERTY_TYPES = frozenset({"rich_text", "title"})
-NAMED_PROPERTY_TYPES = frozenset({"select", "status"})
 
 
 class NotionExtractor:
@@ -49,8 +47,6 @@ def _load_data_as_documents(self, notion_obj_id: str, notion_obj_type: str) -> s
 
     def _get_notion_database_data(self, database_id: str) -> str:
         """Fetch all pages from a Notion database and return as a Markdown table."""
-        assert self._notion_access_token is not None, "Notion access token is required"
-
         # Retrieve database metadata
         database_data = self._client.retrieve_database(database_id=database_id)
 
@@ -100,7 +96,6 @@ def _get_notion_database_data(self, database_id: str) -> str:
 
     def _get_notion_block_data(self, page_id: str) -> str:
         """Fetch and process Notion block data."""
-        assert self._notion_access_token is not None, "Notion access token is required"
         result_lines_arr = []
 
         # Retrieve page metadata
@@ -207,42 +202,46 @@ def _read_table_rows(self, block_id: str) -> str:
     def _extract_property_value(self, property_value: dict[str, Any]) -> object:
         """Extract the value of a Notion property."""
         column_type = property_value["type"]
-        if column_type == "multi_select":
-            return ", ".join(option["name"] for option in property_value[column_type])
-        if column_type in TEXT_PROPERTY_TYPES:
-            return (
-                property_value[column_type][0]["plain_text"]
-                if property_value[column_type]
-                else ""
-            )
-        if column_type in NAMED_PROPERTY_TYPES:
-            return (
-                property_value[column_type]["name"]
-                if property_value[column_type]
-                else ""
-            )
-        if column_type == "number":
-            return property_value.get("number")
-        if column_type == "date":
-            date_data = property_value.get("date", {})
-            return (
-                {"start": date_data.get("start"), "end": date_data.get("end")}
-                if date_data
-                else None
-            )
-        if column_type == "formula":
-            formula_value = property_value[column_type]
-            return (
-                formula_value.get("number")
-                if isinstance(formula_value, dict)
-                and formula_value.get("type") == "number"
-                else formula_value
-            )
-        if column_type == "created_by":
-            # Handle created_by type
-            created_by_data = property_value.get("created_by", {})
-            return created_by_data.get("name") if created_by_data else None
-        return property_value[column_type]
+        match column_type:
+            case "multi_select":
+                value = ", ".join(
+                    option["name"] for option in property_value[column_type]
+                )
+            case "rich_text" | "title":
+                value = (
+                    property_value[column_type][0]["plain_text"]
+                    if property_value[column_type]
+                    else ""
+                )
+            case "select" | "status":
+                value = (
+                    property_value[column_type]["name"]
+                    if property_value[column_type]
+                    else ""
+                )
+            case "number":
+                value = property_value.get("number")
+            case "date":
+                date_data = property_value.get("date", {})
+                value = (
+                    {"start": date_data.get("start"), "end": date_data.get("end")}
+                    if date_data
+                    else None
+                )
+            case "formula":
+                formula_value = property_value[column_type]
+                value = (
+                    formula_value.get("number")
+                    if isinstance(formula_value, dict)
+                    and formula_value.get("type") == "number"
+                    else formula_value
+                )
+            case "created_by":
+                created_by_data = property_value.get("created_by", {})
+                value = created_by_data.get("name") if created_by_data else None
+            case _:
+                value = property_value[column_type]
+        return value
 
     def _extract_cell_text(self, cell: list[dict]) -> str:
         """Extract text content from a table cell."""