refactor(web): convert enums to as-const in subscription-list

Convert 7 TypeScript enums in the plugin-detail-panel/subscription-list
components to as-const objects with companion type aliases:

- SubscriptionListMode (types.ts)
- CreateButtonType (create/types.ts)
- AuthorizationStatusEnum, ClientTypeEnum (create/hooks/use-oauth-client-state.ts)
- ApiKeyStep (create/hooks/use-common-modal-state.ts)
- LogTypeEnum (log-viewer.tsx, file-local)
- EditStep (edit/apikey-edit-modal.tsx, file-local)

All consumers use EnumName.MEMBER as values or EnumName as types; no
runtime reflection, so the conversion preserves the public API. Drops
7 entries from web/eslint-suppressions.json for the erasable-syntax-only/enums
rule and removes file entries that became empty.

Partially addresses #27998.

Co-authored-by: Claude <noreply@anthropic.com>

Author: jeanibarz

web/app/components/plugins/plugin-detail-panel/subscription-list/create/hooks/use-common-modal-state.ts

@@ -26,10 +26,11 @@ import { useSubscriptionList } from '../../use-subscription-list'
 // Types
 // ============================================================================
 
-export enum ApiKeyStep {
-  Verify = 'verify',
-  Configuration = 'configuration',
-}
+export const ApiKeyStep = {
+  Verify: 'verify',
+  Configuration: 'configuration',
+} as const
+export type ApiKeyStep = typeof ApiKeyStep[keyof typeof ApiKeyStep]
 
 const CREDENTIAL_TYPE_MAP: Record<SupportedCreationMethods, TriggerCredentialTypeEnum> = {
   [SupportedCreationMethods.APIKEY]: TriggerCredentialTypeEnum.ApiKey,

web/app/components/plugins/plugin-detail-panel/subscription-list/create/hooks/use-oauth-client-state.ts

@@ -13,16 +13,18 @@ import {
   useVerifyAndUpdateTriggerSubscriptionBuilder,
 } from '@/service/use-triggers'
 
-export enum AuthorizationStatusEnum {
-  Pending = 'pending',
-  Success = 'success',
-  Failed = 'failed',
-}
-
-export enum ClientTypeEnum {
-  Default = 'default',
-  Custom = 'custom',
-}
+export const AuthorizationStatusEnum = {
+  Pending: 'pending',
+  Success: 'success',
+  Failed: 'failed',
+} as const
+export type AuthorizationStatusEnum = typeof AuthorizationStatusEnum[keyof typeof AuthorizationStatusEnum]
+
+export const ClientTypeEnum = {
+  Default: 'default',
+  Custom: 'custom',
+} as const
+export type ClientTypeEnum = typeof ClientTypeEnum[keyof typeof ClientTypeEnum]
 
 const POLL_INTERVAL_MS = 3000
 

web/app/components/plugins/plugin-detail-panel/subscription-list/create/types.ts

@@ -1,6 +1,7 @@
-export enum CreateButtonType {
-  FULL_BUTTON = 'full-button',
-  ICON_BUTTON = 'icon-button',
-}
+export const CreateButtonType = {
+  FULL_BUTTON: 'full-button',
+  ICON_BUTTON: 'icon-button',
+} as const
+export type CreateButtonType = typeof CreateButtonType[keyof typeof CreateButtonType]
 
 export const DEFAULT_METHOD = 'default'

web/app/components/plugins/plugin-detail-panel/subscription-list/edit/apikey-edit-modal.tsx

@@ -23,10 +23,11 @@ type Props = {
   pluginDetail?: PluginDetail
 }
 
-enum EditStep {
-  EditCredentials = 'edit_credentials',
-  EditConfiguration = 'edit_configuration',
-}
+const EditStep = {
+  EditCredentials: 'edit_credentials',
+  EditConfiguration: 'edit_configuration',
+} as const
+type EditStep = typeof EditStep[keyof typeof EditStep]
 
 const normalizeFormType = (type: string): FormTypeEnum => {
   switch (type) {

web/app/components/plugins/plugin-detail-panel/subscription-list/log-viewer.tsx

@@ -21,10 +21,11 @@ type Props = {
   className?: string
 }
 
-enum LogTypeEnum {
-  REQUEST = 'request',
-  RESPONSE = 'response',
-}
+const LogTypeEnum = {
+  REQUEST: 'request',
+  RESPONSE: 'response',
+} as const
+type LogTypeEnum = typeof LogTypeEnum[keyof typeof LogTypeEnum]
 
 const LogViewer = ({ logs, className }: Props) => {
   const { t } = useTranslation()

web/app/components/plugins/plugin-detail-panel/subscription-list/types.ts

@@ -1,7 +1,8 @@
-export enum SubscriptionListMode {
-  PANEL = 'panel',
-  SELECTOR = 'selector',
-}
+export const SubscriptionListMode = {
+  PANEL: 'panel',
+  SELECTOR: 'selector',
+} as const
+export type SubscriptionListMode = typeof SubscriptionListMode[keyof typeof SubscriptionListMode]
 
 export type SimpleSubscription = {
   id: string

web/eslint-suppressions.json

@@ -6984,16 +6984,6 @@
       "count": 1
     }
   },
-  "app/components/plugins/plugin-detail-panel/subscription-list/create/hooks/use-common-modal-state.ts": {
-    "erasable-syntax-only/enums": {
-      "count": 1
-    }
-  },
-  "app/components/plugins/plugin-detail-panel/subscription-list/create/hooks/use-oauth-client-state.ts": {
-    "erasable-syntax-only/enums": {
-      "count": 2
-    }
-  },
   "app/components/plugins/plugin-detail-panel/subscription-list/create/index.tsx": {
     "no-barrel-files/no-barrel-files": {
       "count": 3
@@ -7013,20 +7003,12 @@
       "count": 3
     }
   },
-  "app/components/plugins/plugin-detail-panel/subscription-list/create/types.ts": {
-    "erasable-syntax-only/enums": {
-      "count": 1
-    }
-  },
   "app/components/plugins/plugin-detail-panel/subscription-list/delete-confirm.tsx": {
     "tailwindcss/enforce-consistent-class-order": {
       "count": 4
     }
   },
   "app/components/plugins/plugin-detail-panel/subscription-list/edit/apikey-edit-modal.tsx": {
-    "erasable-syntax-only/enums": {
-      "count": 1
-    },
     "no-restricted-imports": {
       "count": 1
     }
@@ -7052,9 +7034,6 @@
     }
   },
   "app/components/plugins/plugin-detail-panel/subscription-list/log-viewer.tsx": {
-    "erasable-syntax-only/enums": {
-      "count": 1
-    },
     "tailwindcss/enforce-consistent-class-order": {
       "count": 4
     },
@@ -7086,11 +7065,6 @@
       "count": 2
     }
   },
-  "app/components/plugins/plugin-detail-panel/subscription-list/types.ts": {
-    "erasable-syntax-only/enums": {
-      "count": 1
-    }
-  },
   "app/components/plugins/plugin-detail-panel/tool-selector/components/index.ts": {
     "no-barrel-files/no-barrel-files": {
       "count": 7