chore: fix oxlint warnings - remove redundant nullish coalescing, unused vars, and unnecessary escapes

Fixes #25189

Changes:
- Remove redundant `?? {}` / `|| {}` in spread operators (spread undefined is safe)
- Remove unnecessary backslash escapes in single-quoted strings
- Rename unused parameter `testCode` → `_testCode`
- Convert ternary statement to if/else in embed.js
- Replace regex with `.endsWith()` for simpler string matching
- Add safe optional chaining in test file

16 files changed, 30 insertions, 28 deletions

Author: agenthaulk

sdks/nodejs-client/src/http/client.test.ts

@@ -39,15 +39,15 @@ const jsonResponse = (
     ...init,
     headers: {
       "content-type": "application/json",
-      ...(init.headers ?? {}),
+      ...init.headers,
     },
   });
 
 const textResponse = (body: string, init: ResponseInit = {}): Response =>
   new Response(body, {
     ...init,
     headers: {
-      ...(init.headers ?? {}),
+      ...init.headers,
     },
   });
 

sdks/nodejs-client/src/index.test.ts

@@ -14,7 +14,7 @@ const jsonResponse = (body: unknown, init: ResponseInit = {}): Response =>
     ...init,
     headers: {
       "content-type": "application/json",
-      ...(init.headers ?? {}),
+      ...init.headers,
     },
   });
 

web/app/components/base/markdown-with-directive/index.tsx

@@ -91,7 +91,7 @@ function buildDirectiveRehypePlugins(): PluggableList {
   ])
 
   const attributes: Record<string, AttributeDefinition[]> = {
-    ...(defaultSanitizeSchema.attributes ?? {}),
+    ...defaultSanitizeSchema.attributes,
   }
 
   for (const [tagName, allowedAttributes] of Object.entries(DIRECTIVE_ALLOWED_TAGS))

web/app/components/base/markdown/streamdown-wrapper.tsx

@@ -86,7 +86,7 @@ function buildRehypePlugins(extraPlugins?: PluggableList): PluggableList {
   ])
 
   const mergedAttributes: Record<string, AttributeDefinition[]> = {
-    ...(defaultSanitizeSchema.attributes ?? {}),
+    ...defaultSanitizeSchema.attributes,
   }
 
   for (const tag of Object.keys(ALLOWED_TAGS)) {

web/app/components/datasets/documents/detail/metadata/hooks/use-metadata-state.ts

@@ -75,7 +75,7 @@ export function useMetadataState({ docDetail, onUpdate }: UseMetadataStateOption
     setEditStatus(true)
   }
   const cancelEdit = () => {
-    setMetadataParams({ documentType: docType || '', metadata: { ...(docDetail?.doc_metadata || {}) } })
+    setMetadataParams({ documentType: docType || '', metadata: { ...docDetail?.doc_metadata } })
     setEditStatus(!docType)
     if (!docType)
       setShowDocTypes(true)

web/app/components/plugins/plugin-detail-panel/subscription-list/__tests__/log-viewer.spec.tsx

@@ -145,7 +145,7 @@ describe('LogViewer', () => {
   })
 
   it('should parse request data when it is raw JSON', () => {
-    const log = createLog({ request: { ...createLog().request, data: '{\"hello\":1}' } })
+    const log = createLog({ request: { ...createLog().request, data: '{"hello":1}' } })
 
     render(<LogViewer logs={[log]} />)
 

web/app/components/workflow-app/hooks/__tests__/use-workflow-run.spec.ts

@@ -501,7 +501,8 @@ describe('useWorkflowRun', () => {
     windowWithDebugControllers.__allTriggersDebugAbortController = { abort: allTriggersAbort }
     const refController = new AbortController()
     const refAbortSpy = vi.spyOn(refController, 'abort')
-    const { getAbortController } = mocks.mockSsePost.mock.calls.at(-1)?.[2] as {
+    const lastCall = mocks.mockSsePost.mock.calls.at(-1)
+    const { getAbortController } = (lastCall?.[2] ?? {}) as {
       getAbortController?: (controller: AbortController) => void
     }
     getAbortController?.(refController)

web/app/components/workflow/hooks/use-nodes-interactions.ts

@@ -1484,7 +1484,7 @@ export const useNodesInteractions = () => {
               targetHandle,
               type: CUSTOM_EDGE,
               data: {
-                ...(edge.data || {}),
+                ...edge.data,
                 sourceType: newCurrentNode.data.type,
                 targetType: targetNodeForEdge.data.type,
                 isInIteration,
@@ -1524,7 +1524,7 @@ export const useNodesInteractions = () => {
               targetHandle,
               type: CUSTOM_EDGE,
               data: {
-                ...(edge.data || {}),
+                ...edge.data,
                 sourceType: sourceNode.data.type,
                 targetType: newCurrentNode.data.type,
                 isInIteration: newNodeIsInIteration,

web/app/components/workflow/nodes/assigner/__tests__/integration.spec.tsx

@@ -320,7 +320,7 @@ describe('assigner path', () => {
         <VarList
           readonly={false}
           nodeId="node-1"
-          list={[createOperation({ operation: WriteMode.set, value: '{\"a\":1}' })]}
+          list={[createOperation({ operation: WriteMode.set, value: '{"a":1}' })]}
           onChange={onChange}
           filterVar={vi.fn(() => true)}
           filterToAssignedVar={vi.fn(() => true)}
@@ -332,9 +332,9 @@ describe('assigner path', () => {
         />,
       )
 
-      fireEvent.change(screen.getByLabelText('code-editor'), { target: { value: '{\"a\":2}' } })
+      fireEvent.change(screen.getByLabelText('code-editor'), { target: { value: '{"a":2}' } })
       expect(onChange).toHaveBeenLastCalledWith([
-        createOperation({ operation: WriteMode.set, value: '{\"a\":2}' }),
+        createOperation({ operation: WriteMode.set, value: '{"a":2}' }),
       ], '{"a":2}')
 
       onChange.mockClear()

web/app/components/workflow/nodes/http/components/__tests__/curl-panel.spec.tsx

@@ -32,7 +32,7 @@ describe('curl-panel', () => {
 
   describe('parseCurl', () => {
     it('should parse method, headers, json body, and query params from a valid curl command', () => {
-      const { node, error } = curlParser.parseCurl('curl -X POST -H \"Authorization: Bearer token\" --json \"{\"name\":\"openai\"}\" https://example.com/users?page=1&size=2')
+      const { node, error } = curlParser.parseCurl('curl -X POST -H "Authorization: Bearer token" --json "{"name":"openai"}" https://example.com/users?page=1&size=2')
 
       expect(error).toBeNull()
       expect(node).toMatchObject({