Commit 49bebfd
committed
perf(api): memoize ProviderManager.get_configurations within request/task scope (#27299)
Incremental step for #27299 — assembling `ProviderConfigurations` runs six
independent DB queries plus a provider-factory load, costing ~1s per call in
production. A single workflow step (e.g. a Retrieval node inside an Iteration)
invokes this path many times through independently-created `ProviderManager`
instances, so per-instance caching is not enough.
- `core/provider_manager.py`: add a module-level
`RecyclableContextVar[dict[str, ProviderConfigurations]]` and memoize the
result in `get_configurations` for the current request/task scope, keyed by
`tenant_id`. The cache is shared across `ProviderManager` instances because
callers routinely spawn fresh ones via `create_plugin_provider_manager`.
- `extensions/ext_celery.py`: call `RecyclableContextVar.increment_thread_recycles()`
inside `FlaskTask.__call__`, matching the Flask `before_request` hook in
`app_factory.py` so per-task caches reset cleanly between Celery tasks on
recycled worker threads.
- `tests/unit_tests/core/test_provider_manager.py`: cover the memoization (hit
within a scope, per-tenant isolation, sharing across `ProviderManager`
instances, reset on new scope) behind an autouse fixture that bumps the
recycle counter for each test.
No cross-request invalidation is introduced — the cache lives only for the
current request/task, so mutations performed through subsequent requests are
always observed. This deliberately scopes the change: it targets the reported
hot path (iterative retrieval/LLM nodes) with no staleness risk.
## Verification
- uv run --group dev basedpyright -> 0 errors, 0 warnings (project-wide).
- pytest tests/unit_tests/core/test_provider_manager.py and related -> 40 passed.
- ruff check / ruff format --check -> clean.1 parent 7862b61 commit 49bebfd
3 files changed
Lines changed: 129 additions & 0 deletions
File tree
- api
- core
- extensions
- tests/unit_tests/core
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| 24 | + | |
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
| |||
60 | 62 | | |
61 | 63 | | |
62 | 64 | | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
63 | 82 | | |
64 | 83 | | |
65 | 84 | | |
| |||
114 | 133 | | |
115 | 134 | | |
116 | 135 | | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
117 | 146 | | |
118 | 147 | | |
119 | 148 | | |
| |||
273 | 302 | | |
274 | 303 | | |
275 | 304 | | |
| 305 | + | |
| 306 | + | |
276 | 307 | | |
277 | 308 | | |
278 | 309 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
78 | 79 | | |
79 | 80 | | |
80 | 81 | | |
81 | 82 | | |
82 | 83 | | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
83 | 87 | | |
84 | 88 | | |
85 | 89 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| 10 | + | |
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
15 | 24 | | |
16 | 25 | | |
17 | 26 | | |
| |||
563 | 572 | | |
564 | 573 | | |
565 | 574 | | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
566 | 660 | | |
567 | 661 | | |
568 | 662 | | |
| |||
0 commit comments