[Refactor/Chore] add missing-override-decorator

[asukaminato0721]

Self Checks

• I have read the Contributing Guide and Language Policy.
• This is only for refactors or chores; if you would like to ask a question, please head to Discussions.
• I have searched for existing issues search for existing issues, including closed ones.
• I confirm that I am using English to submit this report, otherwise it will be closed.
• 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
• Please do not modify this template :) and fill in all the required fields.

Description

these missing override

ERROR Class member `RemoteSettingsSourceFactory.get_field_value` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyConfig.settings_customise_sources` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ApolloSettingsSource.get_field_value` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `NacosSettingsSource.get_field_value` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `NullAppContext.get_config` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `NullAppContext.get_extension` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `NullAppContext.enter` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `FlaskAppContext.get_config` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `FlaskAppContext.get_extension` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `FlaskAppContext.enter` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowRunStatusField.output` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowRunOutputsField.output` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `CotChatAgentRunner._organize_prompt_messages` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `CotCompletionAgentRunner._organize_prompt_messages` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginAgentStrategy.get_parameters` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginAgentStrategy._invoke` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AdvancedChatAppGenerateResponseConverter.convert_blocking_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AdvancedChatAppGenerateResponseConverter.convert_blocking_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AdvancedChatAppGenerateResponseConverter.convert_stream_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AdvancedChatAppGenerateResponseConverter.convert_stream_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AgentChatAppGenerateResponseConverter.convert_blocking_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AgentChatAppGenerateResponseConverter.convert_blocking_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AgentChatAppGenerateResponseConverter.convert_stream_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `AgentChatAppGenerateResponseConverter.convert_stream_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ChatAppGenerateResponseConverter.convert_blocking_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ChatAppGenerateResponseConverter.convert_blocking_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ChatAppGenerateResponseConverter.convert_stream_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ChatAppGenerateResponseConverter.convert_stream_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `CompletionAppGenerateResponseConverter.convert_blocking_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `CompletionAppGenerateResponseConverter.convert_blocking_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `CompletionAppGenerateResponseConverter.convert_stream_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `CompletionAppGenerateResponseConverter.convert_stream_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `NoopDraftVariableSaver.save` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `MessageBasedAppQueueManager._publish` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_blocking_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_blocking_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_stream_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_stream_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PipelineQueueManager._publish` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppQueueManager._publish` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_blocking_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_blocking_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_stream_full_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowAppGenerateResponseConverter.convert_stream_simple_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DatabaseFileAccessController.current_scope` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DatabaseFileAccessController.apply_upload_file_filters` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DatabaseFileAccessController.apply_tool_file_filters` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DatabaseFileAccessController.get_upload_file` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DatabaseFileAccessController.get_tool_file` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ConversationVariablePersistenceLayer.on_graph_start` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ConversationVariablePersistenceLayer.on_event` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ConversationVariablePersistenceLayer.on_graph_end` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PauseStatePersistenceLayer.on_graph_start` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PauseStatePersistenceLayer.on_event` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PauseStatePersistenceLayer.on_graph_end` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `SuspendLayer.on_graph_start` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `SuspendLayer.on_event` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `SuspendLayer.on_graph_end` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TimeSliceLayer.on_graph_start` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TimeSliceLayer.on_event` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TimeSliceLayer.on_graph_end` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TriggerPostLayer.on_graph_start` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TriggerPostLayer.on_event` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TriggerPostLayer.on_graph_end` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.multimodal_send_format` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.http_get` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.storage_load` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.load_file_bytes` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.resolve_file_url` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.resolve_upload_file_url` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.resolve_tool_file_url` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `DifyWorkflowFileRuntime.verify_preview_signature` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowPersistenceLayer.on_graph_start` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowPersistenceLayer.on_event` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WorkflowPersistenceLayer.on_graph_end` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `LocalFileDatasourcePlugin.datasource_provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `LocalFileDatasourcePlugin.get_icon_url` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `LocalFileDatasourcePluginProviderController.provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `LocalFileDatasourcePluginProviderController._validate_credentials` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OnlineDocumentDatasourcePlugin.datasource_provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OnlineDocumentDatasourcePluginProviderController.provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OnlineDriveDatasourcePlugin.datasource_provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OnlineDriveDatasourcePluginProviderController.provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WebsiteCrawlDatasourcePlugin.datasource_provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `WebsiteCrawlDatasourcePluginProviderController.provider_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ProviderConfigurations.__iter__` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ApiExternalDataTool.validate_config` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ApiExternalDataTool.query` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `JavascriptCodeProvider.get_language` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `JavascriptCodeProvider.get_default_code` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `NodeJsTemplateTransformer.get_runner_script` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jinja2TemplateTransformer.transform_response` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jinja2TemplateTransformer.assemble_runner_script` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jinja2TemplateTransformer.get_runner_script` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jinja2TemplateTransformer.get_preload_script` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Python3CodeProvider.get_language` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Python3CodeProvider.get_default_code` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Python3TemplateTransformer.get_runner_script` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `SingletonProviderCredentialsCache._generate_cache_key` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ToolProviderCredentialsCache._generate_cache_key` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `TraceContextFilter.filter` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `IdentityContextFilter.filter` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `StructuredJSONFormatter.format` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `MCPClientWithAuthRetry.__enter__` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `MCPClientWithAuthRetry.list_tools` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `MCPClientWithAuthRetry.invoke_tool` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ClientSession.send_progress_notification` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ClientSession._received_request` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ClientSession._handle_incoming` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ClientSession._received_notification` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ApiModeration.validate_config` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ApiModeration.moderation_for_inputs` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `ApiModeration.moderation_for_outputs` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `KeywordsModeration.validate_config` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `KeywordsModeration.moderation_for_inputs` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `KeywordsModeration.moderation_for_outputs` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OpenAIModeration.validate_config` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OpenAIModeration.moderation_for_inputs` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `OpenAIModeration.moderation_for_outputs` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginDaemonError.__str__` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.fetch_model_providers` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.get_provider_icon` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.validate_provider_credentials` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.validate_model_credentials` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.get_model_schema` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_llm` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_llm_with_structured_output` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.get_llm_num_tokens` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_text_embedding` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_multimodal_embedding` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.get_text_embedding_num_tokens` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_rerank` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_multimodal_rerank` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_tts` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.get_tts_model_voices` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_speech_to_text` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `PluginModelRuntime.invoke_moderation` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jieba.create` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jieba.add_texts` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jieba.text_exists` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jieba.delete_by_ids` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jieba.search` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `Jieba.delete` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `_LazyEmbeddings.embed_documents` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `_LazyEmbeddings.embed_multimodal_documents` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `_LazyEmbeddings.embed_query` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `_LazyEmbeddings.embed_multimodal_query` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ERROR Class member `_LazyEmbeddings.aembed_documents` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator] ...

you can use pyrefly check strict to find them.

Motivation

https://peps.python.org/pep-0698/

Additional Context

No response

[asukaminato0721]

@dosu how to fix this

[dosubot]

To fix these missing @override decorator errors, add the @override decorator to each overriding method. Here's what to do:

1. Add the import at the top of each affected file:

from typing_extensions import override

This is the pattern most commonly used in the Dify codebase [1] since the project targets Python 3.12 [2], which predates typing.override (added in 3.13).

2. Decorate each overriding method with @override:

from typing_extensions import override

class MySubclass(ParentClass):
    @override
    def some_method(self):
        ...

For properties, place @override below @property:

@property
@override
def provider(self) -> SomeType:
    ...

For class methods, place @override below @classmethod [3]:

@classmethod
@override
def from_config(cls, config: Config) -> Self:
    ...

3. Apply systematically. Given the ~100+ violations, you could script this or handle it file-by-file. A quick approach:

• Use pyrefly check strict (as you mentioned) to get the full list
• For each class/method pair, add from typing_extensions import override to the file's imports (if not already present) and place @override on the method

The fix is purely additive — it doesn't change runtime behavior, just improves type-safety by ensuring the type checker verifies that the method actually overrides a parent method (per PEP 698).

To reply, just mention @dosu.

---

Share context across your team and agents. Try Dosu.

[asukaminato0721]

@dosu no, https://docs.python.org/3/library/typing.html#typing.override

it's from 3.12

[dosubot]

You're right, my mistake — typing.override was added in Python 3.12 (PEP 698). Since Dify already targets Python 3.12, you can import directly from the standard library:

from typing import override

No need for typing_extensions. The fix remains the same otherwise — add @override to each overriding method listed in the errors. Thanks for the correction!

To reply, just mention @dosu.

---

Share context across your team and agents. Try Dosu.

[Quantum0uasar]

Hi! I'd like to contribute to this refactoring effort.

I'll scan the codebase for methods that override parent class methods but are missing the @override decorator (using typing.override from Python 3.12+). I'll submit a PR covering a batch of files.

I'll follow the pattern from the example in #36425. Will open a draft PR soon!

[AlsoTheZv3n]

Hi @Quantum0uasar — happy to help split the load on this one. To avoid overlap, I'm planning a focused PR scoped to the five *AppGenerateResponseConverter classes under api/core/app/apps/{advanced_chat,agent_chat,chat,completion,workflow}/generate_response_converter.py (the 20 convert_blocking_full_response / convert_blocking_simple_response / convert_stream_full_response / convert_stream_simple_response errors in that group). Let me know if you'd rather take those yourself and I'll pick a different slice — otherwise I'll open the PR shortly.