Fixes #34520 [Bug] License expiring banner not shown after login until manual page refresh#34524
Open
Kilros0817 wants to merge 1 commit into
Open
Fixes #34520 [Bug] License expiring banner not shown after login until manual page refresh#34524Kilros0817 wants to merge 1 commit into
Kilros0817 wants to merge 1 commit into
Conversation
…login until manual page refresh
dosubot
Bot
added
the
size:S
Author
|
@GarfieldDai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the license expiring banner did not appear immediately after login until the user manually refreshed the page.
The root cause was that the expired_at field in system features was only available for authenticated requests, while the frontend cached system features before login. This caused the dashboard to use stale data without expired_at, preventing the banner from showing.
The fix (Option A): Move expired_at outside the is_authenticated guard so it is available even for unauthenticated calls. The status field remains gated because it contains sensitive information, but expired_at is safe to expose.
This ensures that the banner is displayed immediately after login without requiring a manual page refresh.
Fixes #34520