refactor(web): convert enums to as-const in subscription-list 🤖🤖🤖

[jeanibarz]

Summary

Converts 7 TypeScript enums in the plugins/plugin-detail-panel/subscription-list component tree to as const objects with companion type aliases:

Enum	File	Scope
SubscriptionListMode	subscription-list/types.ts	exported
CreateButtonType	subscription-list/create/types.ts	exported
AuthorizationStatusEnum	create/hooks/use-oauth-client-state.ts	exported
ClientTypeEnum	create/hooks/use-oauth-client-state.ts	exported
ApiKeyStep	create/hooks/use-common-modal-state.ts	exported
LogTypeEnum	subscription-list/log-viewer.tsx	file-local
EditStep	subscription-list/edit/apikey-edit-modal.tsx	file-local

Partially addresses #27998.

Why this is safe

• All consumers use either EnumName.MEMBER as a value or EnumName as a type. The as const object + type alias pattern preserves both the exported name and the set of string values, so the public API is identical.
• No runtime reflection on any of these enums (Object.values/Object.keys/iteration) — checked with grep across the repo, so the special-case patterns from the dosubot comment on refactor(web): In TypeScript, the use of enums should be avoided. #27998 don't apply.
• No string-to-enum coercion (e.g. Status[key as keyof typeof Status]) — all accesses are static member references.

Pattern

Matches the convention from the merged batches (e.g. #33960, #33834) and my prior PR #34565:

export const AuthorizationStatusEnum = {
  Pending: 'pending',
  Success: 'success',
  Failed: 'failed',
} as const
export type AuthorizationStatusEnum = typeof AuthorizationStatusEnum[keyof typeof AuthorizationStatusEnum]

Checklist

• pnpm run type-check — 0 errors
• pnpm run lint:ci — 0 errors (3174 pre-existing warnings, none introduced)
• Tests pass — pnpm run test on the 10 affected test files (294 tests across subscription-list/**/__tests__/)
• Removed the 7 erasable-syntax-only/enums entries from web/eslint-suppressions.json; left other suppressions for those files intact; dropped 4 file entries that became empty.
• Husky pre-commit hook passed (ESLint, tsgo, knip, unit tests)
• Avoids conflict with @mahmoodhamdi's open PR refactor(web): convert 8 enums to as-const objects (batch 6) #33962 (different file set)