fix(api): filter Graphon workflow response events#36249
Draft
laipz8200 wants to merge 3 commits into
Draft
Conversation
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-05-18 08:21:23.273819575 +0000
+++ /tmp/pyrefly_pr.txt 2026-05-18 08:21:10.886753383 +0000
@@ -3105,36 +3105,40 @@
--> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:226:22
ERROR Object of class `NoneType` has no attribute `value` [missing-attribute]
--> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:235:16
+ERROR Argument `SimpleNamespace` is not assignable to parameter `queue_manager` with type `AppQueueManager` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner.__init__` [bad-argument-type]
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:239:55
+ERROR Argument `SimpleNamespace` is not assignable to parameter `workflow_entry` with type `WorkflowEntry` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner._iter_workflow_events` [bad-argument-type]
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:266:61
ERROR Argument `TestWorkflowBasedAppRunner.test_handle_graph_run_events_and_pause_notifications._QueueManager` is not assignable to parameter `queue_manager` with type `AppQueueManager` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner.__init__` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:244:55
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:277:55
ERROR Argument `SimpleNamespace` is not assignable to parameter `workflow_entry` with type `WorkflowEntry` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner._handle_event` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:270:30
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:303:30
ERROR Argument `SimpleNamespace` is not assignable to parameter `workflow_entry` with type `WorkflowEntry` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner._handle_event` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:271:30
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:304:30
ERROR Argument `SimpleNamespace` is not assignable to parameter `workflow_entry` with type `WorkflowEntry` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner._handle_event` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:272:30
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:305:30
ERROR Type `object` is not iterable [not-iterable]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:274:69
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:307:69
ERROR Type `object` is not iterable [not-iterable]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:275:71
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:308:71
ERROR Type `object` is not iterable [not-iterable]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:276:39
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:309:39
ERROR Argument `TestWorkflowBasedAppRunner.test_handle_node_events_publishes_queue_events._QueueManager` is not assignable to parameter `queue_manager` with type `AppQueueManager` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner.__init__` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:287:55
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:320:55
ERROR Argument `SimpleNamespace` is not assignable to parameter `workflow_entry` with type `WorkflowEntry` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner._handle_event` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:295:13
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:328:13
ERROR Argument `SimpleNamespace` is not assignable to parameter `workflow_entry` with type `WorkflowEntry` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner._handle_event` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:305:13
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:338:13
ERROR Argument `SimpleNamespace` is not assignable to parameter `workflow_entry` with type `WorkflowEntry` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner._handle_event` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:316:13
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:349:13
ERROR Argument `SimpleNamespace` is not assignable to parameter `workflow_entry` with type `WorkflowEntry` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner._handle_event` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:332:13
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:365:13
ERROR Argument `SimpleNamespace` is not assignable to parameter `workflow_entry` with type `WorkflowEntry` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner._handle_event` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:346:13
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:379:13
ERROR Argument `TestWorkflowBasedAppRunner.test_handle_start_node_result_events_project_outputs._QueueManager` is not assignable to parameter `queue_manager` with type `AppQueueManager` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner.__init__` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:426:55
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:459:55
ERROR Argument `SimpleNamespace` is not assignable to parameter `workflow_entry` with type `WorkflowEntry` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner._handle_event` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:444:30
+ --> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:477:30
ERROR Argument `_DummyQueueManager` is not assignable to parameter `queue_manager` with type `AppQueueManager` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner.__init__` [bad-argument-type]
--> tests/unit_tests/core/app/apps/test_workflow_app_runner_notifications.py:36:51
ERROR Argument `_DummyWorkflowEntry` is not assignable to parameter `workflow_entry` with type `WorkflowEntry` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner._handle_event` [bad-argument-type]
|
Contributor
Pyrefly Type Coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #36249 +/- ##
==========================================
- Coverage 85.94% 85.94% -0.01%
==========================================
Files 4454 4454
Lines 211360 211379 +19
Branches 39501 39507 +6
==========================================
+ Hits 181653 181668 +15
- Misses 26499 26502 +3
- Partials 3208 3209 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Apply Graphon ResponseStreamFilter to workflow-based app runners so workflow execution consumes filtered graph events in both streaming and blocking paths. Pin Graphon to the PR revision while the change waits for the 0.5.0 release, and update unit coverage for the filtered event stream behavior.
b69ee7f to
dce25a3
Compare
Point the temporary Graphon source pin at the latest langgenius/graphon#146 head after its event filter updates.
99ec228 to
19b334e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResponseStreamFilterin workflow-based app runners before Dify handles graph events.graphonat the revision from feat(events): add graph event filters graphon#146.Merge Blocker
This Draft PR must wait for Graphon 0.5.0 to be released before merge. After the release, replace the temporary git revision pin with the released package constraint.