Added documentation, rearranged exclusion logic in caliper.cc#50
Open
apthorpe wants to merge 4 commits into
Open
Added documentation, rearranged exclusion logic in caliper.cc#50apthorpe wants to merge 4 commits into
apthorpe wants to merge 4 commits into
Conversation
pjh40
reviewed
Jan 24, 2020
Contributor
pjh40
left a comment
pjh40
left a comment
There was a problem hiding this comment.
Thanks for the PR! The demos are pretty rough, but, as they are meant to help people get an idea of how to use the FLPR library, it is great to get them in better shape!
Comment on lines
+12
to
+14
| /file caliper.cc | ||
|
|
||
| /brief Add fictitious function calls at entry and exit point of each external |
Contributor
There was a problem hiding this comment.
I'll have to see about adding the apps directory to the Doxygen generation: right now, it doesn't show up when the doxygen target is built. Does Doxygen recognize forward slashes as commands? I'm only familiar with backslashes.
Author
There was a problem hiding this comment.
I think you're right about Doxygen and the backslashes. Let me fix that and add the mark_executable demo and resubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working through the example code, I added Doxygen comments to caliper.cc and made several minor changes (rearranged exclusion logic, etc.). I don't believe there's any change in behavior regarding how the target file is modified but the diagnostic messages from std::cerr may differ slightly.