[8.x] Mention package for custom claims#7531
Closed
driesvints wants to merge 1 commit into8.xfrom
Closed
Conversation
Member
|
I don't usually recommend or endorse third party packages in the docs unless they are very well known and maintained for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long outstanding issue on the Passport repo is the ability to add custom claims to issued tokens. However, atm league/oauth2-server currently does not provide an easy way to do this.
Until an easy way has been provided so we can add this natively to Passport, I recommend mentioning the laravel-passport-claims package. This will allow people to add their custom claims while we don't need to perform any changes right now in Passport.
The reason why I don't want to go down the path of adding these changes to Passport is because I don't want to diverge too far from the way league/oauth2-server works. It's best to wait until they provide the functionality for us to implement this easily.