[13.x] Cache getLockForPopping() result in DatabaseQueue (#59435)

The lock type is determined by database engine and version, which never
change during a queue worker's lifetime. Cache the result to avoid
repeated PDO attribute lookups, Stringable allocations, regex parsing,
and version_compare calls on every job pop.

Fixes #59350

Author: sumaiazaman

src/Illuminate/Queue/DatabaseQueue.php

@@ -44,6 +44,13 @@ class DatabaseQueue extends Queue implements QueueContract, ClearableQueue
      */
     protected $retryAfter = 60;
 
+    /**
+     * The cached lock type for popping jobs.
+     *
+     * @var string|bool|null
+     */
+    protected $lockForPopping = null;
+
     /**
      * Create a new database queue instance.
      *
@@ -338,6 +345,10 @@ protected function getNextAvailableJob($queue)
      */
     protected function getLockForPopping()
     {
+        if ($this->lockForPopping !== null) {
+            return $this->lockForPopping;
+        }
+
         $databaseEngine = $this->database->getPdo()->getAttribute(PDO::ATTR_DRIVER_NAME);
         $databaseVersion = $this->database->getConfig('version') ?? $this->database->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION);
 
@@ -354,14 +365,14 @@ protected function getLockForPopping()
             ($databaseEngine === 'pgsql' && version_compare($databaseVersion, '9.5', '>=')) ||
             ($databaseEngine === 'vitess' && version_compare($databaseVersion, '19.0', '>='))
         ) {
-            return 'FOR UPDATE SKIP LOCKED';
+            return $this->lockForPopping = 'FOR UPDATE SKIP LOCKED';
         }
 
         if ($databaseEngine === 'sqlsrv') {
-            return 'with(rowlock,updlock,readpast)';
+            return $this->lockForPopping = 'with(rowlock,updlock,readpast)';
         }
 
-        return true;
+        return $this->lockForPopping = true;
     }
 
     /**

tests/Queue/QueueDatabaseQueueUnitTest.php

@@ -196,6 +196,27 @@ public function testBuildDatabaseRecordWithPayloadAtTheEnd()
         $this->assertArrayHasKey('payload', $record);
         $this->assertArrayHasKey('payload', array_slice($record, -1, 1, true));
     }
+
+    public function testGetLockForPoppingIsCached()
+    {
+        $database = m::mock(Connection::class);
+        $queue = new DatabaseQueue($database, 'table', 'default');
+
+        $pdo = m::mock(\PDO::class);
+        $pdo->shouldReceive('getAttribute')->with(\PDO::ATTR_DRIVER_NAME)->once()->andReturn('mysql');
+        $pdo->shouldReceive('getAttribute')->with(\PDO::ATTR_SERVER_VERSION)->once()->andReturn('8.0.36');
+
+        $database->shouldReceive('getPdo')->andReturn($pdo);
+        $database->shouldReceive('getConfig')->with('version')->andReturn(null);
+
+        $method = new \ReflectionMethod($queue, 'getLockForPopping');
+
+        $result1 = $method->invoke($queue);
+        $result2 = $method->invoke($queue);
+
+        $this->assertSame('FOR UPDATE SKIP LOCKED', $result1);
+        $this->assertSame($result1, $result2);
+    }
 }
 
 class MyTestJob