Skip to content

Commit 6f74eb6

Browse files
committed
Drop implicit fallback for invalid sorting directions in collections
1 parent 3cc029e commit 6f74eb6

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

src/Illuminate/Collections/Collection.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1619,10 +1619,9 @@ protected function sortByMany(array $comparisons = [], int $options = SORT_REGUL
16191619

16201620
$prop = $comparison[0];
16211621

1622-
$direction = match (Arr::get($comparison, 1, true)) {
1623-
true, 'asc', SortDirection::Ascending => SortDirection::Ascending,
1624-
false, 'desc', SortDirection::Descending => SortDirection::Descending,
1625-
default => SortDirection::Descending, // for backwards compatibility
1622+
$direction = match (Arr::get($comparison, 1, SortDirection::Ascending)) {
1623+
'asc', SortDirection::Ascending => SortDirection::Ascending,
1624+
'desc', SortDirection::Descending => SortDirection::Descending,
16261625
};
16271626

16281627
if (! is_string($prop) && is_callable($prop)) {

0 commit comments

Comments
 (0)