Open
Conversation
Introduce an `Idempotent` middleware that caches responses keyed by a client-supplied idempotency header, preventing duplicate side-effects when requests are retried. Supports configurable TTL, required/optional key enforcement, user/ip/global scoping, custom header names, concurrent request locking, JSON payload normalization, and redirect replay. Also adds an `#[Idempotent]` controller attribute for declarative usage and registers `idempotent` as a default middleware alias.
shaedrich
reviewed
Mar 31, 2026
| * Handle an incoming request. | ||
| * | ||
| * @param \Illuminate\Http\Request $request | ||
| * @param \Closure $next |
Contributor
There was a problem hiding this comment.
You can add types here:
Suggested change
| * @param \Closure $next | |
| * @param \Closure(\Illuminate\Http\Request): \Symfony\Component\HttpFoundation\Response $next |
|
|
||
| if (is_null($clientKey) || $clientKey === '') { | ||
| if ($required) { | ||
| throw new HttpException(400, "Missing required header: {$header}"); |
Contributor
There was a problem hiding this comment.
You could work with the constants here:
Suggested change
| throw new HttpException(400, "Missing required header: {$header}"); | |
| throw new HttpException(Response::HTTP_BAD_REQUEST, "Missing required header: {$header}"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds first-class idempotency handling for write requests so applications can safely retry POST, PUT, and PATCH operations without duplicating work.
Approach
Examples