[12.x] Fix File::types() silently discarding chain configuration#59324
Draft
JoshSalway wants to merge 2 commits intolaravel:12.xfrom
Draft
[12.x] Fix File::types() silently discarding chain configuration#59324JoshSalway wants to merge 2 commits intolaravel:12.xfrom
JoshSalway wants to merge 2 commits intolaravel:12.xfrom
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
4 tasks
JoshSalway
force-pushed
the
fix/file-types-static-method
branch
from
0a96d34 to
1591066
Compare
The types() method was declared as static, which meant calling it on an existing File instance (e.g. File::image()->max(1)->types(['jpg'])) would silently create a new instance, discarding all prior configuration like max(), min(), etc. This changes types() to work both as a static factory method and as a chainable instance method by leveraging __call and __callStatic magic methods. The underlying logic is moved to setTypes(). Fixes laravel#59242 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verifies that calling types() on an existing File instance preserves prior configuration (e.g. max()) instead of creating a new instance. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JoshSalway
force-pushed
the
fix/file-types-static-method
branch
from
1591066 to
a57ba0b
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
File::types()silently discarding prior chain configuration when called as an instance method (e.g.,File::image()->max(1)->types(['jpg'])would lose themax(1)constraint). Thetypes()method wasstatic, so calling it on an instance created a newFileobject, dropping all previously configured rules.Now works correctly both as a static factory (
File::types('png')) and as a chainable instance method (File::image()->max(1)->types(['jpg'])).Prior work
#59247 by @AnnoyingTechnology took a similar approach to fix this issue but was closed due to timing (13.x release day). This PR builds on that work.
Test plan
max()constraint is preserved whentypes()is called after itFixes #59242