[13.x] Add configurable key prefix to ThrottleRequestsWithRedis#59326
Draft
JoshSalway wants to merge 2 commits into
Draft
[13.x] Add configurable key prefix to ThrottleRequestsWithRedis#59326JoshSalway wants to merge 2 commits into
JoshSalway wants to merge 2 commits into
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Redis-native rate limiting via ThrottleRequestsWithRedis generates raw, non-namespaced Redis keys (e.g., SHA-1 hashes). This breaks in Redis environments where ACLs restrict access by key pattern (common in managed Redis/Valkey services). This adds a configurable key prefix that gets prepended to all Redis keys used by the throttle middleware. The prefix defaults to empty string for backward compatibility, but can be set via setKeyPrefix() or by overriding getKeyPrefix() in a subclass. Fixes laravel#58279 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verifies that the key prefix is prepended to Redis keys and that setKeyPrefix() returns the middleware instance for fluent chaining. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a configurable key prefix to
ThrottleRequestsWithRedisfor Redis ACL compatibility. Redis-native rate limiting generates raw, non-namespaced keys (SHA-1 hashes) which break in Redis environments with ACL key pattern restrictions.The prefix can be set via
setKeyPrefix()or by overridinggetKeyPrefix()in a subclass. Defaults to empty string for full backward compatibility.Test plan
setKeyPrefix()returns$thisfor fluent chainingFixes #58279