[13.x] Add queue methods to inspect jobs#59511
Open
jackbayliss wants to merge 2 commits intolaravel:13.xfrom
Open
[13.x] Add queue methods to inspect jobs#59511jackbayliss wants to merge 2 commits intolaravel:13.xfrom
jackbayliss wants to merge 2 commits intolaravel:13.xfrom
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
39d82e0 to
2967b6c
Compare
queue methods to inspect jobs squash it to save viewing pain doc Update InspectedJob.php csx2 cs wip tests and clean up
we pass it in.. so no need to see it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR there's 3 new methods which can all be accessed from the queue facade:
( which mirrors the size methods )
Each returns a
CollectionofInspectedJob. which is as a lightweight class to expose uuid, job name, attempts and createdAt of each payloadWhich means we can now do cool stuff like:
I use database queues and have logic to ensure certain jobs aren't running during deployment in Laravel Cloud and other infra. IE imagine there's a job that shouldn't be interrupted by a deployment, that's the scenario, if it's running the deployment script waits for it to finish.
This currently means reaching for DB::table, manually decoding the payload, and knowing that the job class is stored under displayName.. we can access size via the queue facade, but there's no clean way to get more job details without understanding the internals hence the PR :)
I've added the method to each driver, most just being an empty collection as this only works for the Redis and Database drivers.
No contract changes, no B/C (i dont think), but contracts etc could be tightened in 14.x
This probably needs some love / direction. Happy for you to take over or tell me what to adjust into something more fitting, or throw it into the abyss, but thought I'd give this a idea a try!