[13.x] Allow null in redirectUsersTo() to match redirectGuestsTo()#59546
Open
sumaiazaman wants to merge 2 commits intolaravel:13.xfrom
Open
[13.x] Allow null in redirectUsersTo() to match redirectGuestsTo()#59546sumaiazaman wants to merge 2 commits intolaravel:13.xfrom
sumaiazaman wants to merge 2 commits intolaravel:13.xfrom
Conversation
PR laravel#59526 added null support to redirectGuestsTo() and the guests parameter in redirectTo(). The users side was missed — redirectUsersTo() still only accepts callable|string, and the $users null check in redirectTo() was not updated.
RedirectIfAuthenticated doesn't handle null redirect like the unauthenticated handler does (laravel#59505). Just accept null in the signature for type consistency — null flows through to if($users) which is false, so RedirectIfAuthenticated is not configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #59526 added
nullsupport toredirectGuestsTo()and the$guestsparameter inredirectTo(). The$usersside was missed:redirectUsersTo()still only acceptscallable|string— missingnullredirectTo()wraps$guestswithis_null()check but not$usersBefore
After
Consistency
redirectGuestsTo()redirectUsersTo()redirectTo($guests, $users)$guests✅,$users❌ → ✅ (this PR)Changes
src/Illuminate/Foundation/Configuration/Middleware.php— AddnulltoredirectUsersTo()signature and$usersnull handling inredirectTo()