[13.x] Use native clamp function#59995
Closed
jnoordsij wants to merge 4 commits intolaravel:13.xfrom
Closed
Conversation
fgaroby
reviewed
May 5, 2026
Member
|
If it's working fine let's just leave it. |
Contributor
Author
|
I mainly did this again given it doesn't really work fine, as the min > max behavior is somewhat incorrect and deviates from what you might expect, hence moving towards a more universal solution would be preferable in my eyes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the manual
Number::clampimplementation with the PHP nativeclamp, which is new in PHP 8.6 (unreleased). See also:clampfunction symfony/polyfill#554In doing so, it also introduces some tests for 'incorrect' behavior on providing reversed bounds, which currently leads to the incorrect and potentially unexpected outcome of always returning the 'max' value. By adding a deprecation now, this functionality can later be dropped to throw the
ValueErrorand match the new default behavior.