fix(auth): localize --no-wait --json hint output#1142
Conversation
The --no-wait --json branch in auth login was hardcoding an English hint string, ignoring the user's configured language. Use the already localized msg.AgentTimeoutHint instead, matching the behavior of the regular --json branch. Also update the corresponding test assertions to match the Chinese localization (the default language). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe ChangesHint Message Localization
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
|
Thanks for the fix, @cloudyan! The only thing blocking this PR is the CLA — could you sign it here? https://cla-assistant.io/larksuite/cli?pullRequest=1142 Once the check turns green we'll review and merge. 🙏 |
The --no-wait --json branch in auth login was hardcoding an English hint string, ignoring the user's configured language. Use the already localized msg.AgentTimeoutHint instead, matching the behavior of the regular --json branch.
Also update the corresponding test assertions to match the Chinese localization (the default language).
Summary
The
--no-wait --jsonbranch inauth loginwas hardcoding an English hint string, ignoring the user's configured language. This change makes it use the already-localizedmsg.AgentTimeoutHintinstead, matching the behavior of the regular--jsonbranch.Fixes:
lark-cli auth login --domain all --no-wait --jsonnow outputs localized hint text.Summary by CodeRabbit
auth login --no-waitcommand to use localized text instead of hardcoded English guidance.