Skip to content

feat: add contact skill domain guidance#1144

Open
suhui928 wants to merge 2 commits into
larksuite:mainfrom
suhui928:feat/add_user_profile_meta_api
Open

feat: add contact skill domain guidance#1144
suhui928 wants to merge 2 commits into
larksuite:mainfrom
suhui928:feat/add_user_profile_meta_api

Conversation

@suhui928
Copy link
Copy Markdown

@suhui928 suhui928 commented May 28, 2026

Summary

Add contact domain guidance for AI agents and update the contact skill documentation so agents can
better understand when and how to use contact-related CLI commands.

Changes

  • Add contact domain guidance under skill-template/domains/contact.md
  • Update skills/lark-contact/SKILL.md with the generated contact skill content

Test Plan

  • make unit-test
  • go vet ./...
  • gofmt -l .
  • go mod tidy
  • go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6 run --new-from-rev=origin/main

Related Issues

N/A

Summary by CodeRabbit

  • Documentation
    • Added a decision table to choose contact commands based on user vs bot identity.
    • Expanded skill guidance with a critical prerequisite note and a new “colleague status/profile” command example (including sample invocation).
    • Documented multi-match behavior, identifier-type differences, common edge cases (permissions, cross-tenant fields), and out-of-scope actions for clarity.

Review Change Stack

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 28, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8711daf9-a1e1-497a-ace5-6c31da3f51d7

📥 Commits

Reviewing files that changed from the base of the PR and between 0eb1957 and 2d7dcc2.

📒 Files selected for processing (2)
  • skill-template/domains/contact.md
  • skills/lark-contact/SKILL.md
✅ Files skipped from review due to trivial changes (1)
  • skill-template/domains/contact.md

📝 Walkthrough

Walkthrough

This PR updates lark-contact documentation: expands the skill description with prerequisites and examples, and adds a domain guide mapping contact intents to the correct lark-cli contact commands with multi-match and identifier/permission edge-case notes.

Changes

Contact Skill Documentation Update

Layer / File(s) Summary
Skill description and critical guidance
skills/lark-contact/SKILL.md
Updated description frontmatter with detailed usage scenarios and added a CRITICAL instruction to read ../lark-shared/SKILL.md. Added user_profiles.batch_query guidance and example lark-cli invocations.
Contact domain command selection guide
skill-template/domains/contact.md
New domain guide documenting decision logic for choosing lark-cli contact commands by identity (user vs bot), includes a decision table, multi-result behavior, identifier-type notes (open_id vs other id types), visibility/permission edge cases, and out-of-scope redirects.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • larksuite/cli#763: Updates guidance around resolving user identity via lark-cli contact and handling of open_id/identity resolution.

Suggested labels

domain/base

Suggested reviewers

  • kongenpei
  • infeng

Poem

🐰 A skill guide hops into view,
Clear commands in lines anew,
Whether bot or user calls,
The path to contacts now stands true,
Hop on, invoke, and follow through!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: add contact skill domain guidance' clearly and concisely summarizes the main change—adding domain guidance and documentation for the contact skill.
Description check ✅ Passed The description covers all required sections from the template: Summary, Changes, Test Plan, and Related Issues. It provides sufficient detail about the modifications and verification steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added domain/contact PR touches the contact domain size/M Single-domain feat or fix with limited business impact labels May 28, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skill-template/domains/contact.md`:
- Around line 7-12: Links in skill-template/domains/contact.md are using
incorrect relative paths (e.g., `references/lark-contact-search-user.md`,
`../lark-im/SKILL.md`) and thus break; update each Markdown link to use paths
relative to the skill-template/domains/ directory so they resolve correctly (for
example, change `references/...` to `../references/...` or the correct sibling
path), and verify all other instances like
`references/lark-contact-get-user.md`, `../lark-calendar/SKILL.md`, and the
`+search-user`/`+get-user` reference lines are adjusted the same way.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d7d1b5b8-2652-4179-97c8-a27ec2f76a74

📥 Commits

Reviewing files that changed from the base of the PR and between bbef3cb and 0eb1957.

📒 Files selected for processing (2)
  • skill-template/domains/contact.md
  • skills/lark-contact/SKILL.md

Comment thread skill-template/domains/contact.md
MaxHuang22
MaxHuang22 previously approved these changes May 28, 2026
@github-actions
Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@0eb19570336d5200df3196ece7dab7bc681d9ded

🧩 Skill update

npx skills add suhui928/cli#feat/add_user_profile_meta_api -y -g

@suhui928 suhui928 marked this pull request as draft May 28, 2026 13:17
- Add user_profiles batch_query row to the routing table.
- Add a worked example next to the search-user one, with `lark-cli
  schema` first (best practice: don't guess `--data` / `--params`).
- Trim description: drop the duplicated trigger clause, add
  personal_status / signature to the capability list so routing picks
  this skill up for those queries.

Change-Id: Ib32c56f6a389b3c248409228f4c7461453d1dcd3
@suhui928 suhui928 force-pushed the feat/add_user_profile_meta_api branch from 0eb1957 to 2d7dcc2 Compare May 29, 2026 03:10
@suhui928 suhui928 marked this pull request as ready for review May 29, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/contact PR touches the contact domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants