docs: document mail sender list commands#1732
Open
infeng wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
domain/mail
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR adds documentation for user-level sender allowlists/blacklists, expands the lark-mail skill guide with sending, HTML, template, and API resource guidance, and introduces a new reference doc for sender allow/blocked list CLI usage. ChangesSender allowlist/blacklist and mail skill documentation
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@1fdc0782b9bf72d198cc19393d1f698dda257993🧩 Skill updatenpx skills add infeng/cli#feat/15d4aa1 -y -g |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-mail/SKILL.md`:
- Line 4: The front-matter description in SKILL.md is missing sender-management
triggers, so prompts about allow/deny sender workflows may not route to this
skill. Update the existing description text near the top of the file to include
the sender-list keywords already used elsewhere, keeping the current mail
actions coverage intact; use the description field in the skill metadata as the
place to add those sender-management intents.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1b76e2bd-e262-434f-b077-cc54b6c40f3e
📒 Files selected for processing (3)
skill-template/domains/mail.mdskills/lark-mail/SKILL.mdskills/lark-mail/references/lark-mail-user-senders.md
Change-Type: ci-fix
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/lark-mail/SKILL.md (1)
68-69: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winInclude
rules.sortin the confirmation matrix.
Ruleis documented as supporting sorting, and reordering rules can change mail-routing precedence. Leaving it out here lets a mutating workflow skip the required preview/confirmation step.♻️ Proposed fix
-| 修改收信规则 | `rules.create` / `update` / `delete` | ✅ 必须 | +| 修改收信规则 | `rules.create` / `update` / `delete` / `sort` | ✅ 必须 |🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/lark-mail/SKILL.md` around lines 68 - 69, The confirmation matrix is missing `rules.sort`, so the documented rule-reordering action can bypass the required preview/confirmation step. Update the matrix in `SKILL.md` to include `rules.sort` alongside the other rule mutations, keeping the existing `Rule` and `rules.create`/`update`/`delete` entries consistent with the documented workflow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@skills/lark-mail/SKILL.md`:
- Around line 68-69: The confirmation matrix is missing `rules.sort`, so the
documented rule-reordering action can bypass the required preview/confirmation
step. Update the matrix in `SKILL.md` to include `rules.sort` alongside the
other rule mutations, keeping the existing `Rule` and
`rules.create`/`update`/`delete` entries consistent with the documented
workflow.
Change-Type: ci-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Mail command documentation for user mailbox sender lists.
Summary by CodeRabbit
list,batch_create,batch_remove), plus explicit confirmation requirements (nobatch_set/batch_delete).