refactor(embedded-mpv): split session controller into focused collaborators [2/7]#4
Closed
larsemig wants to merge 1 commit into
Closed
refactor(embedded-mpv): split session controller into focused collaborators [2/7]#4larsemig wants to merge 1 commit into
larsemig wants to merge 1 commit into
Conversation
larsemig
force-pushed
the
pr/01-player-controls-core
branch
from
July 7, 2026 19:00
9cbf902 to
8010bc4
Compare
larsemig
force-pushed
the
pr/02-embedded-mpv-decompose
branch
from
July 7, 2026 19:00
2b1f5e5 to
b73b54f
Compare
…rators Mechanical decomposition of the embedded-MPV session controller into focused collaborators under embedded-mpv-player/: - embedded-mpv-command-runner.ts: transport/track/recording IPC delegators with guarded snapshot reconciliation - embedded-mpv-session-factory.ts: pure placeholder-session factories (loading/attaching/error) and the startup-paint wait - embedded-mpv-stalled-tracker.ts: loading-stall timer and stalled flag - embedded-mpv-compositor.ts: host bounds measurement (measureBounds), re-exported from embedded-mpv-format.utils for existing imports No behavior change. The existing embedded-mpv-player component is kept untouched and keeps working against the controller's unchanged public API (commands are now bound fields delegating to the runner). Test coverage extended per Codecov patch report. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
larsemig
force-pushed
the
pr/02-embedded-mpv-decompose
branch
from
July 7, 2026 19:56
b73b54f to
2f9a144
Compare
larsemig
force-pushed
the
pr/01-player-controls-core
branch
from
July 7, 2026 19:56
8010bc4 to
e3c8da6
Compare
Owner
Author
|
Used as template only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Sidenote from the author: My review focus for this series was the architecture, not every implementation detail. If there are specific contribution guidelines I should follow (commit style, PR conventions, test expectations, etc.), please let me know and I will adapt the series accordingly.
Step 2 of the 7-PR series implementing the direction approved in 4gray#1105.
What
Mechanical decomposition of the monolithic embedded-MPV session controller into focused collaborators (503 → 304 lines), preparing it for the shared-controls adapter in step 3:
embedded-mpv-command-runner.ts— IPC command delegation with the exact same guard order and snapshot reconciliationembedded-mpv-session-factory.ts— pure loading/error session snapshot factoriesembedded-mpv-stalled-tracker.ts— stalled-playback timer, verbatim moveembedded-mpv-compositor.ts—measureBounds(byte-identical move);embedded-mpv-format.utilskeeps a re-export shim so existing imports don't breakReview notes
sessionId.set(null)moved from inside the factory to the controller call site (same observable effect).attach(),createAttachingSession(),boundsTick. Nothing existing reads them yet;attach()has unit coverage.ui-playbacksuite green (182 tests, incl. the untouched old component spec).🗺️ Series roadmap (proposal 4gray#1105)
Stacked series: each PR is based on the previous one, so every diff shows only its own step.
🤖 Generated with Claude Code