Include application's command-line in logs#270
Conversation
| context); | ||
| event->parent = parent; | ||
|
|
||
| err = bpf_get_current_comm (event->command, sizeof(event->command)); |
There was a problem hiding this comment.
Maybe bpf_get_cgroup_classid would also be useful to have in the logs.
There was a problem hiding this comment.
Do you mean bpf_get_current_cgroup_id? net_cls seems to be a cgroup v1 only feature.
Signed-off-by: Daiki Ueno <dueno@redhat.com>
Signed-off-by: Daiki Ueno <dueno@redhat.com>
ueno
force-pushed
the
wip/current-comm
branch
2 times, most recently
from
f65cda6 to
cd0cc2f
Compare
Signed-off-by: Daiki Ueno <dueno@redhat.com>
ueno
force-pushed
the
wip/current-comm
branch
5 times, most recently
from
334774d to
6b18097
Compare
The-Mule
left a comment
The-Mule
left a comment
There was a problem hiding this comment.
I am wondering if command is the right name, wouldn't it be more precise to refer to it as executable instead? I have no strong preference about this but command sort of imply full command (line).
Makes sense. Let me rename it to |
This embeds the running application's executable filename in the primary log as well as the crau-query output. To preserve backward compatibility, if the "executable" field is missing in the primary log, an empty string will be assumed. Signed-off-by: Daiki Ueno <dueno@redhat.com>
The-Mule
left a comment
The-Mule
left a comment
There was a problem hiding this comment.
Thanks, looks perfect now.
|
Thanks for the review! |
3 participants
This embeds command line of the running application in the primary log as well as the crau-query output. To preserve backward compatibility, if the "command" field is missing in the primary log, an empty string will be assumed.