Skip to content

Fix am_mod_cfg_rec not being reused.(#36)#37

Open
oss-aimoto wants to merge 1 commit into
latchset:mainfrom
oss-aimoto:reuse_of_am_mod_cfg_rec
Open

Fix am_mod_cfg_rec not being reused.(#36)#37
oss-aimoto wants to merge 1 commit into
latchset:mainfrom
oss-aimoto:reuse_of_am_mod_cfg_rec

Conversation

@oss-aimoto

Copy link
Copy Markdown

Reuse am_mod_cfg_rec.
mellon Sessions are not lost on httpd restart (signal: HUP, USR1).
However, the cache size is not changed.

@simo5

simo5 commented Sep 18, 2020

Copy link
Copy Markdown
Member

My httpd internals memories are a bit rusty in places, but are you moving the mutex from allocation on a global memory pool to a per-process pool ?

@oss-aimoto

Copy link
Copy Markdown
Author

The global memory pool is apr_pool_clear() at Gracefull restart. (by reset_process_pconf() in main.c)
s->process->pool is not cleared, the mutex can be reused.
I refer to the code of mod_ssl.

@simo5

simo5 commented Sep 23, 2020

Copy link
Copy Markdown
Member

I guess the question is how thi affects the usage of the mutex, does it still remain a global mutex that all processes can reach? Or does this change open up the possibility that different processes will se actually different mutexes and not be coordinated anymore ?

@oss-aimoto

Copy link
Copy Markdown
Author

A global mutex that is reachable by all processes.
s-> process-> pool is also a global pool.

@simo5

simo5 commented Sep 24, 2020

Copy link
Copy Markdown
Member

In that case I am ok with this, but I'd like another pair of eyes to take a look.

@thijskh thijskh requested a review from jhrozek January 17, 2022 08:50
@thijskh

thijskh commented Apr 8, 2024

Copy link
Copy Markdown

@jhrozek Can you take a look perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants