Fix memory leak, use reference for track data.

Author: kinyoklion

libs/server-sdk/include/launchdarkly/server_side/hooks/hook.hpp

@@ -353,14 +353,14 @@ class TrackSeriesContext {
      * @param context The context associated with the track call.
      * @param key The event key.
      * @param metric_value Optional metric value.
-     * @param data Optional application-specified data.
+     * @param data Optional reference to application-specified data.
      * @param hook_context Additional context data provided by the caller.
      * @param environment_id Optional environment ID.
      */
     TrackSeriesContext(Context const& context,
                        std::string key,
                        std::optional<double> metric_value,
-                       std::optional<Value> data,
+                       std::optional<std::reference_wrapper<Value const>> data,
                        HookContext const& hook_context,
                        std::optional<std::string> environment_id);
 
@@ -433,7 +433,7 @@ class TrackSeriesContext {
     Context const& context_;
     std::string key_;
     std::optional<double> metric_value_;
-    std::optional<Value> data_;
+    std::optional<std::reference_wrapper<Value const>> data_;
     HookContext const& hook_context_;
     std::optional<std::string> environment_id_;
 };

libs/server-sdk/src/bindings/c/sdk.cpp

@@ -449,6 +449,8 @@ LDServerSDK_TrackMetric_WithHookContext(LDServerSDK sdk,
         TO_SDK(sdk)->Track(*TO_CONTEXT(context), event_name,
                           *TO_VALUE(data), metric_value);
     }
+
+    LDValue_Free(data);
 }
 
 LD_EXPORT(void)
@@ -469,6 +471,8 @@ LDServerSDK_TrackData_WithHookContext(LDServerSDK sdk,
         TO_SDK(sdk)->Track(*TO_CONTEXT(context), event_name,
                           *TO_VALUE(data));
     }
+
+    LDValue_Free(data);
 }
 
 LD_EXPORT(bool)

libs/server-sdk/src/client_impl.cpp

@@ -252,7 +252,7 @@ void ClientImpl::TrackInternal(Context const& ctx,
     // minimal functional difference.
     if (!config_.Hooks().empty()) {
         hooks::TrackSeriesContext series_context(ctx, event_name, metric_value,
-                                                data, hook_context, std::nullopt);
+                                                  data, hook_context, std::nullopt);
         hooks::ExecuteAfterTrack(config_.Hooks(), series_context, logger_);
     }
 

libs/server-sdk/src/hooks/hook.cpp

@@ -146,13 +146,13 @@ TrackSeriesContext::TrackSeriesContext(
     Context const& context,
     std::string key,
     std::optional<double> metric_value,
-    std::optional<Value> data,
+    std::optional<std::reference_wrapper<Value const>> data,
     HookContext const& hook_context,
     std::optional<std::string> environment_id)
     : context_(context),
       key_(std::move(key)),
       metric_value_(metric_value),
-      data_(std::move(data)),
+      data_(data),
       hook_context_(hook_context),
       environment_id_(std::move(environment_id)) {}