fix: surface invalid bigSegmentsStatus as a JSON parse error

beekld · beekld · commit 84a60e4f5644 · 2026-06-09T22:03:49.000-07:00
diff --git a/libs/internal/src/serialization/json_evaluation_reason.cpp b/libs/internal/src/serialization/json_evaluation_reason.cpp
@@ -227,9 +227,10 @@ tl::expected<EvaluationReason, JsonError> tag_invoke(
             auto parsed = boost::json::value_to<tl::expected<
                 enum EvaluationReason::BigSegmentsStatus, JsonError>>(
                 big_segments_status_iter->value());
-            if (parsed) {
-                big_segments_status = *parsed;
+            if (!parsed) {
+                return tl::make_unexpected(parsed.error());
             }
+            big_segments_status = parsed.value();
         }
 
         return EvaluationReason{*kind,

Original file line number	Diff line number	Diff line change
`@@ -227,9 +227,10 @@ tl::expected<EvaluationReason, JsonError> tag_invoke(`
`227`	`227`	`auto parsed = boost::json::value_to<tl::expected<`
`228`	`228`	`enum EvaluationReason::BigSegmentsStatus, JsonError>>(`
`229`	`229`	`big_segments_status_iter->value());`
`230`		`- if (parsed) {`
`231`		`- big_segments_status = *parsed;`
	`230`	`+ if (!parsed) {`
	`231`	`+ return tl::make_unexpected(parsed.error());`
`232`	`232`	`}`
	`233`	`+ big_segments_status = parsed.value();`
`233`	`234`	`}`
`234`	`235`
`235`	`236`	`return EvaluationReason{*kind,`