refactor: make IBigSegmentStore lookup methods noexcept

Author: beekld

libs/server-sdk-dynamodb-source/include/launchdarkly/server_side/integrations/dynamodb/dynamodb_big_segment_store.hpp

@@ -61,8 +61,8 @@ class DynamoDBBigSegmentStore final : public IBigSegmentStore {
            DynamoDBClientOptions options = {});
 
     [[nodiscard]] GetMembershipResult GetMembership(
-        std::string const& context_hash) const override;
-    [[nodiscard]] GetMetadataResult GetMetadata() const override;
+        std::string const& context_hash) const noexcept override;
+    [[nodiscard]] GetMetadataResult GetMetadata() const noexcept override;
 
     ~DynamoDBBigSegmentStore() override;
 

libs/server-sdk-dynamodb-source/src/dynamodb_big_segment_store.cpp

@@ -64,7 +64,7 @@ DynamoDBBigSegmentStore::DynamoDBBigSegmentStore(
 DynamoDBBigSegmentStore::~DynamoDBBigSegmentStore() = default;
 
 IBigSegmentStore::GetMembershipResult DynamoDBBigSegmentStore::GetMembership(
-    std::string const& context_hash) const {
+    std::string const& context_hash) const noexcept {
     Aws::DynamoDB::Model::GetItemRequest request;
     request.SetTableName(table_name_);
     request.SetConsistentRead(true);
@@ -114,7 +114,7 @@ IBigSegmentStore::GetMembershipResult DynamoDBBigSegmentStore::GetMembership(
 }
 
 IBigSegmentStore::GetMetadataResult DynamoDBBigSegmentStore::GetMetadata()
-    const {
+    const noexcept {
     Aws::DynamoDB::Model::GetItemRequest request;
     request.SetTableName(table_name_);
     request.SetConsistentRead(true);

libs/server-sdk-redis-source/include/launchdarkly/server_side/integrations/redis/redis_big_segment_store.hpp

@@ -55,8 +55,8 @@ class RedisBigSegmentStore final : public IBigSegmentStore {
     Create(std::string uri, std::string prefix);
 
     [[nodiscard]] GetMembershipResult GetMembership(
-        std::string const& context_hash) const override;
-    [[nodiscard]] GetMetadataResult GetMetadata() const override;
+        std::string const& context_hash) const noexcept override;
+    [[nodiscard]] GetMetadataResult GetMetadata() const noexcept override;
 
     ~RedisBigSegmentStore() override;
 

libs/server-sdk-redis-source/src/redis_big_segment_store.cpp

@@ -57,7 +57,7 @@ RedisBigSegmentStore::RedisBigSegmentStore(
 RedisBigSegmentStore::~RedisBigSegmentStore() = default;
 
 IBigSegmentStore::GetMembershipResult RedisBigSegmentStore::GetMembership(
-    std::string const& context_hash) const {
+    std::string const& context_hash) const noexcept {
     std::string const include_key = include_key_prefix_ + context_hash;
     std::string const exclude_key = exclude_key_prefix_ + context_hash;
 
@@ -76,7 +76,8 @@ IBigSegmentStore::GetMembershipResult RedisBigSegmentStore::GetMembership(
     return Membership::FromSegmentRefs(included, excluded);
 }
 
-IBigSegmentStore::GetMetadataResult RedisBigSegmentStore::GetMetadata() const {
+IBigSegmentStore::GetMetadataResult RedisBigSegmentStore::GetMetadata()
+    const noexcept {
     sw::redis::OptionalString raw;
     try {
         raw = redis_->get(sync_time_key_);

libs/server-sdk/include/launchdarkly/server_side/integrations/big_segments/ibig_segment_store.hpp

@@ -54,7 +54,7 @@ class IBigSegmentStore {
      * `std::nullopt`). Returns an error if the lookup itself failed.
      */
     [[nodiscard]] virtual GetMembershipResult GetMembership(
-        std::string const& context_hash) const = 0;
+        std::string const& context_hash) const noexcept = 0;
 
     /**
      * @brief Returns store-level metadata used by the SDK to detect staleness.
@@ -63,7 +63,7 @@ class IBigSegmentStore {
      * `std::nullopt` if no metadata has ever been written (the store was
      * never populated), or an error if the lookup itself failed.
      */
-    [[nodiscard]] virtual GetMetadataResult GetMetadata() const = 0;
+    [[nodiscard]] virtual GetMetadataResult GetMetadata() const noexcept = 0;
 
    protected:
     IBigSegmentStore() = default;

libs/server-sdk/tests/big_segment_store_wrapper_test.cpp

@@ -27,7 +27,8 @@ namespace {
 // times GetMetadata was called and lets a test block until a target count.
 class FakeBigSegmentStore : public integrations::IBigSegmentStore {
    public:
-    GetMembershipResult GetMembership(std::string const&) const override {
+    GetMembershipResult GetMembership(
+        std::string const&) const noexcept override {
         std::unique_lock lock(mutex_);
         ++membership_calls_;
         cv_.notify_all();
@@ -37,7 +38,7 @@ class FakeBigSegmentStore : public integrations::IBigSegmentStore {
         return membership_;
     }
 
-    GetMetadataResult GetMetadata() const override {
+    GetMetadataResult GetMetadata() const noexcept override {
         std::lock_guard lock(mutex_);
         ++metadata_calls_;
         cv_.notify_all();

libs/server-sdk/tests/big_segments_builder_test.cpp

@@ -23,10 +23,10 @@ using namespace std::chrono_literals;
 class StubStore final : public IBigSegmentStore {
    public:
     GetMembershipResult GetMembership(
-        std::string const& /*context_hash*/) const override {
+        std::string const& /*context_hash*/) const noexcept override {
         return Membership::FromSegmentRefs({}, {});
     }
-    GetMetadataResult GetMetadata() const override {
+    GetMetadataResult GetMetadata() const noexcept override {
         return std::optional<StoreMetadata>{};
     }
 };